Ret FCFS Rotation Helper - Page 6

Thaeryn · 04/29/09, 1:16 PM

I'm pretty up in the air about the range check thing... I feel like I'm already sliding too far into the "hand-holding" area with this addon. To be fair, if you are focused on using the addon the whole fight, you'll probably be dead to the 101 types of fire or AoE damage in the game. Then again, the more info on my screen, the better. I don't want a "this is how to play your class perfectly" addon, but I do want to keep a high amount of utility.

I'll consider the range check, but no promises. It also depends on how much work it would be... I'm notoriously lazy.

As far as the sub-menu... I'm a bit stumped as well. The paladin I originally wrote this for is having the same problem, and she said it was showing up under SexyMap as well (GREAT addon btw). Does it show up under any other addons for anyone else, or could this be something specific to SexyMap?

Heck · 04/29/09, 1:38 PM

Yeah, it's under SexyMap for me as well. Not a huge issue for me as long as I know where it is. If you can't figure it out, I"d add something to the readme file to let people know where to find it if it's missing.

rea123 · 04/29/09, 6:09 PM

In point of fact the reason I've jumped on this mod is that I found myself more aware of my surroundings while using it, since I wasn't staring at action bars (a while back) or cooldown bars (more recently) working out what was going to fall next and what key it was on. The "current" icon is large enough to be easily recognised in peripheral vision, and the fact that the priority is packed into one (main) icon means that it requires less concentration. Or that's what I found, anyway.

• frmorrison · 04/30/09, 11:05 AM

Originally Posted by Thaeryn

I'll consider the range check, but no promises. It also depends on how much work it would be... I'm notoriously lazy.

This mod does something pretty well, helps you to know which buttons to press when in melee range. I think that is enough, I wouldn't want to see this mod get feature creep.

I have had issues with Sexymap putting stuff underneath it before.

Ahhnold · 04/30/09, 3:20 PM

Thaeryn: Kudos on such a useful addon. I am also against having a range checker.

The only suggestions that I think would make the mod even more useful would be to have multiple priority profiles (mainly just for fighting undead) and maybe an option to make the Avenging Wrath icon flash when it is off of cooldown to make it more visible. I still sometimes forget about it during battle.

Thank you.

Covertghost · 05/01/09, 10:57 AM

Great mod, a toggled cooldown graphic might be pretty useful though (for judging how close things are to clashing, you could really get rid of your bars entirely if this was done)

rea123 · 05/01/09, 10:09 PM

Hey,

OK - as stated above, I am strongly against range being taken into account for the spell decisions, and I think the majority of posters so far are in agreement. However, like I say, I do like the idea of the mod displaying some indication of out-of-rangeness for fights where finding the edge of the hit-box is preferable. As it happens, I've enjoyed playing with this mod, and am in the process of writing a Fury equivalent for my main character's off-spec, as I am entirely new to the wonderful world of warrior DPS. While doing so, I implemented the sort of range checking that I have in mind, so it was natural for me to come back and hack this into my own version of S.H.I.T.

Now I'm not going to ask for these changes to be incorporated into the official version, but I guess it can't hurt to share my tweaks in case others are like-minded.

However, I must make it clear right now, that while I may be able to help with questions regarding these changes, you will be monkeying around with the addon code. If you follow these steps and later have an issue with the mod, I do not want to hear of Thaeryn being hassled with support queries. Warranty is void if seal is broken! Also, naturally, the changes are version-specific - v1094. No promises on future updates.

Anyway, the changes I made were as follows. In the method:

function SHIT:OnUpdate(elapsed)

I modified the final "else" to become "end", and removed the following "end". So:

...
    elseif SHITdb.showon == 3 and GetSpellInfo(SHIT.L["Crusader Strike"]) ~= null then
        if UnitClassification("target") ~= "worldboss" then
            return
        end
    end

    SHIT:DecideSpells()
 
end

Then following the line:

	SHIT.textureList["current"]:SetTexture(GetSpellTexture(spell))

I added the following code:

      SHIT.textureList["current"]:SetVertexColor(1, 1, 1);

      local range = IsSpellInRange(spell, "target");
      if range ~= nil and range == 0 then
            SHIT.textureList["current"]:SetVertexColor(0.8, 0.1, 0.1);
      end

Logicality · 05/02/09, 6:37 PM

I am going to be trying this out soon, just noticed something strange regarding Avenging Wrath in your wording. You state that the add-on prioritizes it for when there is a free GCD, but it is off the GCD, so it really should just be prioritized when it is up.

Kallell · 05/02/09, 6:58 PM

Not sure if this is just my computer or not, but the mod seems to reset the transparency everytime I log in. I set it to 0, and next time I log in, the slider is still at 0, but it has a normal level of transparency again. If I move it up and then back down, it properly disappears. Thanks for a great mod!

Tiberius · 05/02/09, 6:58 PM

Originally Posted by Thaeryn

I'm pretty up in the air about the range check thing... I feel like I'm already sliding too far into the "hand-holding" area with this addon. To be fair, if you are focused on using the addon the whole fight, you'll probably be dead to the 101 types of fire or AoE damage in the game. Then again, the more info on my screen, the better. I don't want a "this is how to play your class perfectly" addon, but I do want to keep a high amount of utility.

I'll consider the range check, but no promises. It also depends on how much work it would be... I'm notoriously lazy.

As far as the sub-menu... I'm a bit stumped as well. The paladin I originally wrote this for is having the same problem, and she said it was showing up under SexyMap as well (GREAT addon btw). Does it show up under any other addons for anyone else, or could this be something specific to SexyMap?

For the SexyMap problem could you put the priority tab in a minimize (+) under SHIT so it isn't on the main interface menu with the other addons unless you maximize it and it show the priority tab.

valygiarth · 05/06/09, 8:58 AM

I'd like to thank the author & testers.
This mod is really awesome.

Heck · 05/14/09, 5:59 PM

So this is now officially my favorite Paladin-specific mod... ahead of Pally Power. I can't remember the last time I've looked at my toolbar, other than to swap which judgement I'm using.

One tweak I'd like to see is to add a cooldown counter to the "on deck" ability. In some situations where my "Use Now" ability is on a short CD (usually less than 2 seconds) I find myself automatically looking at what's the next ability "on deck" (the indicator to the right of center). I've been trying to ween myself away from my instinctive "spam judgement" habit, and I always find myself looking for crusader strike to pop up. If the on deck ability had a counter, I could make a snap decision if I'd rather wait for the next ability (which may be higher up in our FCFS combat system) or hit the one that is coming off cooldown first. This is really only an issue when the cooldowns of the two abilities are within the span of a single GCD.

The configuration menu still seems to be showing up under SexyMap for some reason. I know where it hides, though, so not a huge issue.

rea123 · 05/15/09, 4:31 AM

I doubt that would be a hard change to implement, but I'm not sure it would be a good idea for the purposes you state. FCFS does not have a priority system; FCFS means First Come First Serve, and means literally that. FCFS with clash resolution is where the priority system comes into play, and for optimal DPS, clash resolution should only be invoked for two skills with identical cooldowns; specifically ones whose cooldown will be 0 when the current GCD expires.

In this case, the mod correctly shows the higher priority. If the "next" ability is higher in your priority list, that will be because it will come off cooldown after the "current" one does, so choosing next over current would be a violation of FCFS.

Of course a skilled player may have situational reasons to break from FCFS - low mana or AoE groups that the tool is not entirely suited for - but I would be concerned that implementing a feature to disregard FCFS lies outside the scope of this tool.

Exemplar · 05/15/09, 8:42 AM

Originally Posted by Heck

If the on deck ability had a counter, I could make a snap decision if I'd rather wait for the next ability (which may be higher up in our FCFS combat system) or hit the one that is coming off cooldown first. This is really only an issue when the cooldowns of the two abilities are within the span of a single GCD.

Why? As proven over in the Ret thread (with math), delaying a currently available ability (even our "worst" damage ability) by 0.1 seconds for a "better" ability (including our "best") to come off of cooldown is a loss of DPS. Always hit what is currently available - never wait.

beatific · 05/15/09, 8:46 AM

Originally Posted by Heck

Used this last night during our continuation on Mimiron. Invaluable tool. Let me keep an eye on my character instead of looking at bars waiting for abilities to come off cooldown.

I did notice that it would occasionally "go off", but like has been said above, I assumed that it just meant everything was on CD.

Being able to add in AoW or Sacred Shield as the lowest priority would be nice, but not totally necessary. I've just macro'd my Sacred Shield to spam whisper me when there's 10 seconds remaining... keeps it from every going down. Of course, when things get dicey and I spam the button to make sure it's up, then I get a ridiculous amount of whispers. Other than that, I've been very impressed with the mod so far.

I'm just now getting around to downloading this add-on and so I'm reading through the thread and the macro mentioned here intrigues me. How do you code a macro to tell you when your SS has been up for 50 seconds and then to whisper you? I'm a wow-Luddite so I don't really want to download that mod that tells you when your buff is expiring or whatever that is mentioned in the ret thread and the whispering idea seems great. It's difficult paying attention to action bars, stuff going on around the boss' feet (hello mimiron p4), and then having to peek up at my SS buff and gauge the timer + my potential upcoming free gcd. Thanks for your help !