Why would I want a dippy-bird to play my character for me?

The add-on, as it is now, only SUGGESTS what ability you should use next. Given issues of either range or the number of targets within melee range you will deviate from what is suggested... hence then making the add-on an overall dps LOSS. I hated one button macros on my hunter. Frost Bolt spam on a frost mage (besides frost being a sub par dps spec) is a big turn-off to almost everyone that plays mage. Did people really enjoy being shadow bolt spamming warlocks in BC? I really don't want a one-button mod for my paladin's dps cycle.

Here are the top CPU time using Addons (reported by Broker_CPU) after just idling for 10 minutes in Dalaran (right after login) in my Healadin spec:

Addon	CPU time
PitBull3 (including LibRock)	2.6s
Ace2	1.2s
Bartender4	870ms
Ace3	745ms
SHIT	700ms
PitBull-PowerBar	575ms
PitBull-Aura	155ms
RatingBuster	150ms
AuctionMaster	125ms

(Just Ace2 and Ace3 are external libraries, all others are embedded.)

The rows below SHIT are just there to show how rapidly the CPU time drops after the first few top Addons.

I think the problem is that you have a whole load of GetSpellInfo() calls all over the place. Especially all that calls for each combat log entry and - for the worst - on each OnUpdate (which happens for each frame). You have some "elapsed" in your OnUpdate there, but it seems like you never check it, so this event handler is executed very often.

From what I can see, all that GetSpellInfo() calls can be optimized heavily - by just doing it when it's needed (e.g. on login and after that only on talent change).

And you could also reduce your table lookups very much:
* All that table lookups in SHIT and SHITdb could be changed to local variables. To be exact, all lookups there are two table lookups, because SHIT and SHITdb themselfes are globals. So you would cut your table lookups to the half by just holding a local copy of that two table references.
* And you could hold local copies of the API function references that you call in combat. That would save you a global table lookup for each call.

Btw: Using more tables and loops would simplify and shorten your config code (especially the config frame) a lot


Thanks.

I'll also add my praise for this add-on. As an officer/raid leader, there are times when my head's got to be on a proverbial swivel, and add-ons like this definitely help for keeping my DPS respectable.

I personally prefer EventHorizon for fights where I can just tunnel vision and let the e-peen soar (XT, Vezax, e.g.), but for multi-tasking, the large visual cue from SHIT is just about perfect.

A while back, I posted on the wowinterface board re: this addon not recognizing SS casts on other people. Any chance of changing that to more of a plain timer when its cast, rather then (I'm assuming) reading your buffs?

Range checking was discussed near the beginning of the thread; at the time the addon didn't have even the visual cue that you were out of range. The general (i.e. not unanimous) view was that having the spell-selection algorithm change based on range was - though possible - not desirable. With a visual cue that you're out of range, you should be (and I have no reason to doubt that you are) able to figure out what to do yourself. Worse, in my view, incorporating range checks into the selection algorithm could lead to you not realising that a sub-optimal spell was being flagged simply because you stepped an inch or two outside melee range.

The great thing about this sort of addon, and what separates them from the infamous shot-macros, is that such addons are not selecting a spell for you. They are merely condensing a lot of information into a small space, so that they are in effect giving you more freedom to make reasoned choices than if your mental CPU is at 90% just watching cooldown bars.