A recent hard push has put the Paladin module for SimulationCraft into position for peer review:
All relevant (dps-related) talents, glyphs, set bonuses, and librams are supported with the exception of those talents dealing with blessings and auras. No "dynamic" support for these talents has been added. We must continue to simply use static override.xxx for turning them on/off.
Only a rudimentary knowledge of code is necessary to review the code. There are a number of "FIXME" comments sprinkled throughout sc_paladin.cpp noting areas where I'm a little fuzzy on the mechanics. Any answers you can provide would be greatly appreciated.
In particular, since I do not play a Paladin, comments on the section of code that builds up a default action_list_str would be very helpful. I'd like to come up with a decent priority list based upon player talents/glyphs.
Seals act differently for Prot and Ret specs. SoV will trigger from
Judgement if you have Judgements of the Just also HotR will trigger SoV.
Addressing some of the Fixme comments:
2H Weapon spec only affects weapon-based attacks (CS, DS, Judgements,
Seals) but not spells (Consecration and Exorcism). Since the spells are
a small source of damage, it may be easier lessen the % of damage given
by 2H spec.
HotR is just 4x your weapon damage (shown in the screen), so things like
gaining attack power will buff HotR hits.
Attacks that are immune to parry/dodge: Judgement, Hammer of Wrath,
Avenger's Shield, and Shield of Righteousness (spells as well).
I am pretty sure Seal hits can weapon-speed adjusted AP contribution.
Holy Power doesn't affect Judgements (Judge used melee crit).
Glyph of Seal of righteousness only affects Seal hits (no Judgement
hits).
The application of the SoV DoT uses the combat roll (so can miss, dodge,
or parry). SoV Seal hit will hit if the attack that triggered it hit.
Millions of words are written annually purporting to tell how to beat the races, whereas the best possible advice on the subject is found in the three monosyllables: 'Do not try.'
Thanks, Ashstrike! I updated the sim sample output using your Armory.
A couple clarifications comments/questions:
(1) Regarding HotR: I am determining the "DPS" in "4xDPS" by calculating a weapon hit and then dividing by the swing time. I am currently dividing by the hasted swing time and not the base weapon swing time.
(2) Regarding the Seal hits with weapon components: Are the weapon speeds normalized?
A couple un-addressed questions for those uncomfortable perusing the code:
(A) Tier9-2pc: I understand that it is currently bugged. Do we know the expected behavior?
(B) When Righteous Vengeance procs does it behave like Deadly Poison (tick timer uninterrupted) or Ignite (tick timer rescheduled)?
(C) When Reckoning procs, is it still considered a melee swing capable of triggering Seals?
Thanks, Ashstrike! I updated the sim sample output using your Armory.
A couple clarifications comments/questions:
(1) Regarding HotR: I am determining the "DPS" in "4xDPS" by calculating a weapon hit and then dividing by the swing time. I am currently dividing by the hasted swing time and not the base weapon swing time.
(2) Regarding the Seal hits with weapon components: Are the weapon speeds normalized?
A couple un-addressed questions for those uncomfortable perusing the code:
(A) Tier9-2pc: I understand that it is currently bugged. Do we know the expected behavior?
(B) When Righteous Vengeance procs does it behave like Deadly Poison (tick timer uninterrupted) or Ignite (tick timer rescheduled)?
(C) When Reckoning procs, is it still considered a melee swing capable of triggering Seals?
1. HotR's damage is just 4x weapon dps.
2. Seal hits are not normalized.
A. The behavior is based on your melee crit, however melee crit has a 4.8 crit suppression on a boss.
B. Like Ignite, the damaging debuff rolls.
C. Reckoning is an extra melee swing (if you get damaged) that will proc Seals, assuming it wasn't dodge/parried.
Last edited by frmorrison : 09/17/09 at 2:23 PM.
Millions of words are written annually purporting to tell how to beat the races, whereas the best possible advice on the subject is found in the three monosyllables: 'Do not try.'
B. Like Ignite, the damaging debuff rolls. RV tics every 2 seconds and if you crit between tics, it just adds to the next tic of RV..
My understanding of Deadly Poison and Ignite is that they both "roll" the damage into the next tick. The difference between them is that Ignite will defer ticks. When Ignite procs from a crit, the current ticking Ignite is canceled with its damage rolled into the new Ignite which will occur at proc+2sec.
I read from your description of RV that ticks happen methodically every 2sec regardless of refresh.
My understanding of Deadly Poison and Ignite is that they both "roll" the damage into the next tick. The difference between them is that Ignite will defer ticks. When Ignite procs from a crit, the current ticking Ignite is canceled with its damage rolled into the new Ignite which will occur at proc+2sec.
I read from your description of RV that ticks happen methodically every 2sec regardless of refresh.
06:28:10> [Peppu's] Crusader Strike hits [Expert's Training Dummy] for 1 Physical.(1720 Overkill) *
06:28:11> [Expert's Training Dummy] is afflicted by [Peppu's] Righteous Vengeance.
06:28:12> [Peppu's] Judgement of Corruption hits [Expert's Training Dummy] for 1 Holy.(2115 Overkill) *
06:28:13> [Peppu's] Righteous Vengeance is refreshed on [Expert's Training Dummy].
06:28:15> [Expert's Training Dummy] suffers 1 Holy damage from [Peppu's] Righteous Vengeance.(287 Overkill)
06:28:17> [Expert's Training Dummy] suffers 1 Holy damage from [Peppu's] Righteous Vengeance.(287 Overkill)
Got my twink to a dummy and tried until I got chain crits, it behaves like Ignore/Deep Wounds, else there would have been a tick at 06:28:13
Hello.
Light the fuse.
For all my homies.
Do not run, we are your friends.
I've finished implementing support for defense-related stats (including diminishing returns) which in turn enabled support for boss auto-attack combat table. I can now model Reckoning, Redoubt, Holy Shield Discharge, etc.....
At this point it is decent enough to put out a release.
Well, the paladins are now officially supported.
But there are no other paladin simcraft files than 'Paladin_T9.simcraft'. There is nothing to calculate and Paladin_T9.simcraft is linked with the Priest tierset.
Well, the paladins are now officially supported.
But there are no other paladin simcraft files than 'Paladin_T9.simcraft'. There is nothing to calculate and Paladin_T9.simcraft is linked with the Priest tierset.
Argh. I need to look-up the word "official". It seems.
I see lots of T9 BiS floating around, but what about T8 BiS? Point me in the right direction and I'll get these profiles filled out.
EDIT: Of course, one can always just download your profile from the Armory:
I see lots of T9 BiS floating around, but what about T8 BiS? Point me in the right direction and I'll get these profiles filled out.
For Ret, I made a 3.1 BiS thread (using T8). It may have fallen off the page, but just search for past threads from the last 75 days.
I would use the Plate Priority list (most guilds limit leather items to Ferals/Rogues).
Millions of words are written annually purporting to tell how to beat the races, whereas the best possible advice on the subject is found in the three monosyllables: 'Do not try.'
For Ret, I made a 3.1 BiS thread (using T8). It may have fallen off the page, but just search for past threads from the last 75 days.
I would use the Plate Priority list (most guilds limit leather items to Ferals/Rogues).
Awesome! I'll put the profiles together and and add them to Raid_T8 and Raid_T9 so that they show up on the SampleOutput wiki pages in addition to being part of the Win/OSX downloads.
I realized I made an error when I answered earlier to the question on with 2T9's behavior:
Here is the correct answer:
A. The crit % is based on your melee crit (so is affected by the boss melee crit suppression and all raid melee crit buffs). It does double damage (also the crit damge is affected by the meta gem crit damage bonus).
Millions of words are written annually purporting to tell how to beat the races, whereas the best possible advice on the subject is found in the three monosyllables: 'Do not try.'
I realized I made an error when I answered earlier to the question on with 2T9's behavior:
Here is the correct answer:
A. The crit % is based on your melee crit (so is affected by the boss melee crit suppression and all raid melee crit buffs). It does double damage (also the crit damge is affected by the meta gem crit damage bonus).
Thanks for the follow-up! This has been addressed in r3342.
FYI: I also just fixed reported bugs in Art of War and Reckoning.
Need to rebuild that wiki and get out a new release.
Do you know if this has been empirically tested? I use hasted DPS in my MATLAB simulations as well, as I was under the impression that the spell uses character screen DPS to determine damage.
Do you know if this has been empirically tested? I use hasted DPS in my MATLAB simulations as well, as I was under the impression that the spell uses character screen DPS to determine damage.
Yes, it is 4x the paper doll's dps number. I might have worded it incorrectly, but I don't know if this model is going to simulation tanking dps anyway.
Millions of words are written annually purporting to tell how to beat the races, whereas the best possible advice on the subject is found in the three monosyllables: 'Do not try.'
Do you know if this has been empirically tested? I use hasted DPS in my MATLAB simulations as well, as I was under the impression that the spell uses character screen DPS to determine damage.
You can easily check it just by browsing combat logs actually. You'll notice the damage Hammer of the Righteous deals doesn't go up when Bloodlust is cast, while it should go up if it were affected by haste. I can probably get a shaman to help me try this out using Windfury totem for better testing as well if desired, but I'm certain it's based on your DPS before haste.
buff /bÊŒf/ Pronunciation[buhf]
–verb (used with object)
- to reduce or deaden the force of
Before I put effort into the T10 BiS simulation profiles, I wanted to see if anyone else had already started on it.
Nobody on the modeling side has started this effort. Please use wowhead profiles as your "golden" if at all possible. We can generate the profiles from there.
Nobody on the modeling side has started this effort. Please use wowhead profiles as your "golden" if at all possible. We can generate the profiles from there.
Here are the Wowhead profiles that refer to the T10 BiS plate items for a Retribution Paladin.