I have a question about the trinkets, how much should we rely on the engines ep values for them ? It's giving Tia's Grace heroic and Cyclone as superior to Fluid Death and Prestor's. Is this correct or should I rely on the trinket graph found in the assassination guide ?

I also found that weapons are not sorted by EP.

Great UI, Antiarc, feels very polished. A few suggestions, however:

Would it be possible to put the gear on a different scroll area from the stats and EP values? (Similarily to Caffeine's UI) For example, you might want to see how your hit rating changes when you change your ranged weapon without scrolling back and forth.

It also seems as if saving snapshots of your gear doesn't save the state of the "Settings"-tab. This is a little annoying as I know, for example, that I never have the 30% bleed debuff in my 10 man raids, so currently I will have to uncheck that checkbox every time I load a snapshot to get correct EP values.

I'd also love implementation of the alchemy profession. It's just a little annoying to have to fake it with blacksmith sockets, etc.

Great UI many thanks to you to make that for us!

Would it be possible to add an option so we could export/import it with an editor like it is with Caffeine's Shadowcraft-test? So it would fix the problem with the "Settings"-Tab.

@Fae:

1. Indeed - the UI shows any selected glyphs, or glyphs with an EP value.
2. It does indeed. The assumption is that if you're using the Tricks glyph, you're using it on cooldown and receiving it from another rogue on cooldown. The engine doesn't allow for "you receive tricks, but don't give it", and you giving it but not receiving it is obviously not a DPS increase, so it's not worth modeling in this context.
3. I can clean up the nonexistent items. I did an initial import of gear from Wowhead, and then additional gear is loaded as it is discovered on people. Obviously this means a bit of cleanup may be necessary.
4. Additional versions of Stormreach will be automatically added to the item list as people with them equipped import their characters. I'll clean the non-stat versions.
5. PVP Set bonuses are indeed not supported. It should be trivial for me to support them; I'll add them.
6. Unheeded Warning is still using pre-4.0.6 values. I'll see if I can update the engine to support it, but if it's already done, or someone else wants to tackle it, I'd appreciate it. My strengths lie in application design, not theorycraft.
7. Revealing Strike is not modeled by the engine right now - hence, its DPS value is shown as 0.

@Rubbersoul Settings should be persisted both in the save/load, and in the hashbang after the URL. If it's not, it's a bug. The intent is that those two features should serve as a replacement for a typical export.

Edit: Settings fixed; boolean "false" values were not being preserved properly. Additionally, I merged two fixes from Caffeine (julienp) that should correct two nasty little bugs (thanks!)

Sorry - the talent DPS calculations come back from the engine with RvS as 'not implemented' - it looks like that's because the engine throws an exception when trying to compute its DPS contribution. See https://github.com/Aldriana/ShadowCr...init__.py#L248

The engine does compute RvS, what is not implemented is the lack of the talent itself. That is: it's trying to come up with an EP (a dps difference actually) value for the talent but the modeler is throwing this exception when setting it off, hence the talent_ranking asserts somethign went wonky when feeding the modeler.

The wording isn't great, but talents that show up as "not implemented" in the talent EP calculations are talents that are required, and not having them isn't implemented (so their value can't really be calculated). Master Poisoner and Cut to the Chase behave similarly.

Right - what's happening underneath the hood is found here: https://github.com/Aldriana/ShadowCr...init__.py#L864

Basically, there's two things that can be done if you request a cycle that includes RvS but don't take the talent - throw an error (which is what we do) or assume you want to remove RvS from the cycle as well and automatically correct. Personally, I think from a library perspective what we're currently doing is correct - it only does what you tell it to do, and doesn't assume it knows what you want. It *could* be changed to handle this case if people think it better, but I'd be more inclined to stick something in the talent evaluation logic to automatically update the cycle instead.

I went ahead and added checkboxes for "tricks on cooldown" and "receiving tricks from another rogue". After a bit more exploration, I decided they made sense.

I'm fine with RvS as-is. The rotation options already include an option for "don't use it", so if you want to see what your DPS would be without it, there's that, and there's not another DPS talent to spend that point on, so it's a moot point.

Auto-regem is asking me to use 4 Delicate Chimera's Eyes.

Other than that, loving the interface, good work guys.

I'm rewriting the single-item reforge stuff right now. I made some nasty mistakes when upgrading it to use Blizzard's compacted reforge format. Auto-reforge remains unaffected.