ShadowCraft: Rogue spreadsheet for 4.0 - Page 49

Antiarc · 12/03/11, 4:53 PM

It's working fine for me here. Can you paste your profile link? Have you tried "Refresh from armory"?

• Aldriana · 12/03/11, 4:56 PM

T13 2pc doesn't seem to be activating. Or at least, if you take a clean important of my armory and replace the gloves with T12 heroic, damage goes up when you'd expect it go down as its breaking T13 2pc without restoring T12 4pc.

Rotekin · 12/03/11, 4:57 PM

OK it wasn't working for me, even with an armory import, but then checking/unchecking the "Use Prepot" option seemed to trigger it, it also made the glyph values calculate. However, re-setting my spec back to my e.g. "Imported Combat" seemed to break it again until I once again triggered something via the settings.

aitsu · 12/03/11, 5:01 PM

The chart does seem to come up eventually. I'm not sure why it's taking so long, but it did come up this last time.

Antiarc · 12/03/11, 5:02 PM

Something is blasting the engine - it's getting stuck somewhere, so folks are going to see their DPS numbers not updating until I can fix it. Give me a bit to check it out.

Antiarc · 12/03/11, 5:06 PM

@Aldriana - I'm seeing DPS go from to 37771 -> 37749.2 (-21.9) when swapping your gloves for T12 heroic. That seems right to me?

Tekloth · 12/03/11, 5:22 PM

I'm getting weird reforges currently on SC; it's telling me to reforge all out from mastery/crit to haste/expertise, although I'm assassination (tried refreshing from armory and changing around gems/reforges, it always ends up refoging to expertise/haste) and as far as I know, mastery should be above both haste and expertise in EP values with assassination. Is the engine just thinking that I'm specced combat for some reason or is there something else behind those numbers?
Tekloth @ Darksorrow-EU - ShadowCraft

Antiarc · 12/03/11, 6:20 PM

@Aldriana -- There seems to be an issue in your compute_damage() function that's causing it to get stuck in an infinite loop. Given these inputs:

data = {'mg': 'chaotic', 'b': [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13], 'sta': [20, 5902, 190, 1015, 1151, 781, 2253, 553], 'g': [71047, 71129, 71541, 71537, 71131, 77026, 71467, 71428135, 71538, 78421, 72880, 68994, 68927, 72811, 77945, 77946, 71152], 'settings': {'duration': 260, 'oh_poison': 'dp', 'tricks': True, 'mh_poison': 'ip'}, 'pot': 1, 'oh': [1.4, 922.18, 4099, 15], 'l': 85, 'mh': [1.8, 1185.66, 4099, 15], 'gly': ['backstab', 'slice_and_dice', 'tricks_of_the_trade', 'shadow_dance'], 'r': 'Human', 't': ['0230030000000000000', '0020000000000000000', '0332031321310012321'], 'th': [2, 1488.2, None, 16], 'ro': {'min_envenom_size_backstab': 5, 'use_hemorrhage': 'never', 'use_revealing_strike': 'sometimes', 'ksp_immediately': 'false', 'use_rupture': True, 'min_envenom_size_mutilate': 4, 'clip_recuperate': 0}, 'pro': ['engineering', 'jewelcrafting'], 'prepot': 1}

the "while True:" portion of the method loops forever, with the attacks per second/old attacks per second toggling between:

{'oh_autoattacks': 1.4655539786451635, 'backstab': 0.3192385415804453, 'mh_autoattack_hits': 0.9869378128987019, 'mh_autoattacks': 1.1398753167240159, 'instant_poison': 0.7491754744226387, 'rupture_ticks': (0, 0, 0, 0, 0, 0.5), 'ambush': 0.055854925669271846, 'oh_autoattack_hits': 1.2689200451554739, 'eviscerate': [0, 0, 0, 0, 0, 0.12336300833779293], 'deadly_poison': 0.3333333333333333}

{'oh_autoattacks': 1.4655539786451635, 'backstab': 0.3192382989557763, 'mh_autoattack_hits': 0.9869378128987019, 'mh_autoattacks': 1.1398753167240159, 'instant_poison': 0.7491754010503555, 'rupture_ticks': (0, 0, 0, 0, 0, 0.5), 'ambush': 0.055854925669271846, 'oh_autoattack_hits': 1.2689200451554739, 'eviscerate': [0, 0, 0, 0, 0, 0.12336296049968136], 'deadly_poison': 0.3333333333333333}

This is causing the engine to lock up and effectively DOS other requests. PM me if you'd like details on my testing harness.

I'm working through it, but you obviously know the intent of the code better, so if there's something obvious there, I figure you might see it first.

The engine is locking up when computing the DPS value of the premeditation talent.

In the time being, I'm just bombing out at 20 passes to keep things functional.

• Aldriana · 12/03/11, 6:32 PM

Originally Posted by Antiarc

@Aldriana - I'm seeing DPS go from to 37771 -> 37749.2 (-21.9) when swapping your gloves for T12 heroic. That seems right to me?

If you just straight swap it out, you lose about 20 DPS. If you then auto gem and reforge, you go up about 2-300 DPS (I don't have exact numbers due to the aforementioned site issues). And gaining hundreds of DPS by breaking a set bonus worth (depending on exact gear) 500-700 EP seems... unlikely.

As for the loop: I'll look at it. Its a problem in the sub model which I'm not as familiar with, but I'll see what I can do.

Antiarc · 12/03/11, 6:51 PM

I've fixed the T13-2pc issue. It was checking for the presence of 4 pieces, rather than just 2.

Tiriine · 12/03/11, 7:04 PM

Arrow of Time - Item - World of Warcraft

I think that this may be showing a lot lower on the trinket list than it should be. Its very close to The Hungerer - Item - World of Warcraft which is ranked much higher on the list.

• Aldriana · 12/03/11, 7:17 PM

Looks like you have a reasonable patch for the issue; I'm not entirely sure why its failing to converge adequately with that particular set of inputs, but putting a limit on the iteration to prevent future issues is probably a good idea anyway. Its probably worth looking at why the sub model isn't converging in the first place (as that's a bit concerning, honestly) but for the moment halting the iteration early is probably sufficient.

One other UI point: it doesn't seem to be picking up the new epic gems - its treating the one in my cloak as an empty socket. Would be nice to get those working at some point.

Xenden · 12/03/11, 7:19 PM

Originally Posted by Tiriine

Arrow of Time - Item - World of Warcraft

I think that this may be showing a lot lower on the trinket list than it should be. Its very close to The Hungerer - Item - World of Warcraft which is ranked much higher on the list.

It is only calculating the value of the agility, not the value of the proc.

aitsu · 12/03/11, 7:54 PM

Originally Posted by Tiriine

Arrow of Time - Item - World of Warcraft

I think that this may be showing a lot lower on the trinket list than it should be. Its very close to The Hungerer - Item - World of Warcraft which is ranked much higher on the list.

I think something else is going on here. This item has jumped all over the place in my list. Sometimes it's right up there with the hungerer, and then it drops right back to the bottom.

Antiarc · 12/03/11, 7:56 PM

Arrow of Time is fixed. Epic gems are added. The server's still really struggling to keep up with the engine - I'm profiling it to see if I can get request times down, but traffic always surges after a patch - it's over 3x normal right now - and the new engine introduced a performance regression somewhere that's stressing my little VPS's CPU. Just be patient with it!