I am not sure what to do with imported attack power yet. Scripts in shadowcraft engine had it set to 250. I assume it is just base value and we don't count AP given by agility there. For now I just subtract 2*agility from imported value.
During Cataclysm, it was only [Dragonscale Leg Armor] that gave us 190 AP. Thats also the same value you can find in cata scripts for ShadowCraft-Engine. There are some other outdated enchants with raw AP, but none of them should be relevant any more.
So I am also a bit confused where is this 250 AP coming from. In my opinion, it should be set to zero. Armory confirms this by not showing any AP for my character (while it does display some for my alts that are still using AP enchants).
Unless someone more informed can step in and point out what are we missing, I'd just set it 0.
Also, thanks for your contribution. I did not have a chance to test your script yet, but if it does what it should, it's a huge step forward for daily usage of ShadowCraft - I got a bit tired of typing various gearset stats all the time.
Last edited by Fae : 10/10/12 at 3:16 AM.
Reason: fixed wowhead link
I can't remember the specific thought process when I updated those scripts a few months back. Maybe I misread an enchant, maybe an enchant was changed during beta, or maybe I left a value there for demonstration's sake. The AP / Agi / Crit / etc values weren't meant to be precise at the time, just something I could use that vaguely compares to what SimC had so I could look for bugs in both clients.
Make sure what you're passing is the sum from gear (including gems and enchants) though. We handle base stats, buffs, spec perks, etc in the backend. I believe the stats passed through the Blizz API include many of those effects.
ps. Feel free to use and change the code. I will try to make it more usable, but I absolutely can't give any time estimate on it.
I have made it more usable. It now imports talents, trinkets and recognizes equipped t14 bonus. I also included modified assassination and combat scripts from shadowcraft. I moved everything to github here.
Will the shadowcraft tool ever be updated so it works as it did in cataclysm? I have no knowledge of how to use the shadowcraft engine without the website ui and as i found it to be such an invaluable tool i am wondering if there are any plans to recreate it for MoP?
I hope work with the new tool is going well, without it I am using wowreforge and askmrrobot and neither give me the same confidence as the old shadowcraft tool, and askmrrobot is plain wrong at times.
Any idea when the beta or alpha of the tool will be ready for testing?
Well, in terms of the engine, its in relatively good shape - there's still some tweaks and improvements that could be made, but I think people are feeling reasonably comfortable about the numbers its generating.
In terms of the UI, so far as I know no one is even working on it, so... your guess is as good as mine, really.
head: Agile Retinal Armor
Agile Primal Diamond: +216 agi
Agile Primal Diamond is a meta gem
Error at slot: head
Error type: <type 'exceptions.KeyError'>
Traceback (most recent call last):
File "X:\ShadowCraft\scripts\mop_combat_import.py", line 77, in <module>
lst = character_data.get_gear_stats()
File "X:\ShadowCraft\scripts\import_character.py", line 408, in get_gear_stats
if not sockets[gemNumber][u'type'] in gemColorToSocketColors[tmpGem['data'][u'gemInfo'][u'type'][u'type']]:
While I am kinda familiar with python, I'm not familiar with running something as large as ShadowCraft (I'm currently a student of the python language). When I try to open it and just execute the combat_mop.py file, I get some errors and since I'm not familiar with the program I'm not sure what to edit in order to get it running on my system. Any help would be greatly appreciated.
Traceback (most recent call last):
File "C:\Python27\dazer-ShadowCraft-Engine-8dbcff8\scripts\mop_combat.py", line 4, in <module>
NameError: name '__file__' is not defined
I'm sure it's simple, but it's clearly something I haven't seen covered in class or with my own tinkerings around.
I get the feeling you're trying to launch it through IDLE, rather than Command Prompt (or Terminal/Konsole/whatever). Try navigating to the folder in whichever app is relevant to your OS, and run the interpreter from there. Running things through IDLE function slightly different from the way python code is usually run.