ShadowCraft for Mists of Pandaria - Page 6

theherecy · 12/14/12, 1:43 PM

Originally Posted by Aldriana

The thing to keep in mind with ShadowCraft is that its really not a single monolithic tool. There's at least 3 distinct components, written by different people, involved. Notable in this case is that the logic that computes DPS and EP values is entirely distinct from the reforger/gem optimizer. The reforger is a separate piece of logic that takes the EP values provided by that module and attempts to find the best possible reforge. So while the reforger has been known to make some slightly strange decisions, that doesn't mean the EP values and DPS estimate are in any way in doubt; a problem with the reforger and a problem with the DPS calculator are two very different things.

I will also note that this isn't intended as a knock on the reforger; reforging is actually a very hard problem, and to guarantee the globally optimum reforge would be ridiculously computationally intensive. As such, by necessity it uses heuristics and simplifying assumptions to find a "pretty good" reforge in a reasonable amount of time. However, this also necessarily means that sometimes it will miss things, so there will be situations where you can manually fiddle the EP values to increase the DPS estimate.

This is spot on what I wanted to hear, thankyou!

"Also...This shadowcraft discussion is starting to get really off topic. Maybe a mod could move this discussion where it goes?"

I was just thinking the same.

Drejz · 12/16/12, 9:56 AM

I have a question regarding the EP value of arrow breaking windclock(ABW) vs Malevolent Gladiator's Cape of Prowess(pvp season 12)
When using shadowcraft as combat it values the pvp cloak quite high(even higher than ABW heroic) which seems odd considering the amount of agi on ABW and the fact that it have haste + exp vs mastery + exp on the pvp cloak. Is this a bug or am i completely missing something obvious?

Faergun · 12/16/12, 6:43 PM

Hi folks,

Thanks for getting the UI up again, glad to have shadowcraft back in action for the less technically minded such as myself!

Miniature Winter Veil Christmas Tree doesn't seem to be registering as a dagger for some reason. Not sure what the problem is....

Psilocin · 12/17/12, 3:15 PM

I think the DPS scores for the weapon comparison dropdown are reversed when you have a Crystallized gem socketed. When I put a crystallized in the socket and compare gear, it lists the DPS as being lower than many weapons, and when I remove the gem, it lists it as having higher DPS. For example, I have the RF Claws of Shek'zeer and it lists it with gem as 19027.9 in the gear comparison menu, and as 20402.1 without the gem socketed. It still calculated the right DPS in the total DPS window. Not a game breaking bug, but just thought I'd post it.

Roketsu86 · 12/17/12, 4:51 PM

Originally Posted by Psilocin

I think the DPS scores for the weapon comparison dropdown are reversed when you have a Crystallized gem socketed. When I put a crystallized in the socket and compare gear, it lists the DPS as being lower than many weapons, and when I remove the gem, it lists it as having higher DPS. For example, I have the RF Claws of Shek'zeer and it lists it with gem as 19027.9 in the gear comparison menu, and as 20402.1 without the gem socketed. It still calculated the right DPS in the total DPS window. Not a game breaking bug, but just thought I'd post it.

Shadowcraft knows that the legendary gems are unique-equip, so I'd venture to guess that's why. In the drop-down menu the dps gains are calculated based on your current equipment, so it sees you have one on already and knows the new item won't be able to have on as well.

Unomeme · 12/18/12, 4:55 AM

Having an issue where everytime i click reforge I get a different list of changes. Any clues?

metzli · 12/18/12, 9:09 AM

This is because every time you reforge your EP values change.

Indz · 12/18/12, 3:39 PM

Blizzard updated their API to include Item Upgrade Level, so now your Items will import with the correct Upgrade Level.
Click on the Cogwheel and hit Refresh from Armory. If you are having any issues please let me know.

Jakani · 12/18/12, 4:03 PM

I ran into a strange equipment evaluation bug.

If I have the two trinkets: Woundripper Medallion and Bottle of Infinite Stars(LFR), the trinket ranking shows the LFR Bottle higher than the normal Bottle.

You can load my profile from Armory, and swap Woundripper Medallion in for Searing Words to see this effect.
Jakani @ Perenolde-US - ShadowCraft

Indz · 12/18/12, 4:23 PM

Looks like the ep values for the procs are wrong, when equipping a trinket with an on use-effect. Only the ranking is wrong, not the dps calculation. I will fix it tomorrow.

Icerslair · 12/18/12, 7:12 PM

ye i have issues again with shadowcraft.

icer @ barthilas

seems the item level upgrades dont come across and i have to keep adding them.

*edit* Just saw a setting in SETTINGS (drop down box) that asks to show weapon upgrade. I have this on now it works fine.

Also for some reason it keeps putting my exp to like 6.28% and my hit to like 6.5%. Try it. Jump on my char and click reforge. No idea why... so i have my own reforge at this stage.

Grimwolf · 12/18/12, 11:38 PM

Originally Posted by Icerslair

Also for some reason it keeps putting my exp to like 6.28% and my hit to like 6.5%. Try it. Jump on my char and click reforge. No idea why... so i have my own reforge at this stage.

Shadowcraft is working fine for you on my computer. After reforging, I have you at 1383 rating on expertise. You're assassination spec, so you don't need to cap that. Crit and haste are better for you than exp. After reforging I also have you at 2832 rating on hit. That is too high, but you have a lot of hit gear. Shadowcraft has everything reforged out of hit, so it's doing what it can. Your gemming seems fine, because the bonuses outweigh gemming out of hit. It seems you're stuck with too much hit until you get new gear.

jagreenm · 12/22/12, 10:14 PM

Thanks for the excellent work on this.

One thing to note: [Signet of the Shieldwall] is not showing on the shadowcraft site as upgradeable although it is upgradeable in game.

Thanks!

Haileaus · 12/25/12, 11:06 PM

I'm trying to make sense of the damage formulas in Shadowcraft and am wondering where AP comes in for non-normalized weapon damage. I see:

 def get_weapon_damage(self, hand, ap, is_normalized=True):
        weapon = getattr(self.stats, hand)
        if is_normalized:
            damage = weapon.normalized_damage(ap) + self.get_weapon_damage_bonus()
        else:
            damage = weapon.damage(ap) + self.get_weapon_damage_bonus()
        return damage

and while I can find the normalized weapon damage formula I hate yet to find anything for weapon.damage(ap). There is the damage returned in "def get_weapon(self, weapon_data, item_data):" but I don't see any as a function of AP. Anyone able to lead me to the right bit of code?

Edit:
Alternatively I suppose it could just use normal weapon damage without any AP scaling but considering the scaling in the normalized function, AP is passed into the weapon.damage function, and that would make most things not scale with AP it seems unlikely.

Edit 2: Seeing now that strikes that use wep damage seem to be normalized, so then only autoattacks would not scale with AP if there really isn't any scaling in the non-normalized function. Still seems odd though.

• Aldriana · 12/26/12, 3:14 AM

Not sure which branch you're looking at, but: https://github.com/Aldriana/ShadowCr.../stats.py#L164