ShadowCraft for Mists of Pandaria - Page 7

TxH2oSkier · 01/03/13, 3:55 AM

Im having an issue tonight with ShadowCraft .. i upgraded my Troll-Toll Tabi Boots from Dominance Offensive .. and since ive done this . when i log out and log back in .. it wont recognize any boots. Lookin in the list .. seems it doesnt recognize it as an upgradable item even though it is ... and when i look further none of the Dominance Offensive items show an upgrade even though they are upgradable ... is there something i'm missing here ..

Haileaus · 01/07/13, 4:52 PM

For subtlety, using an opener is showing as a dps loss, and Ambush and Garrote appear to be doing the same damage as there is no change going from one to another. Seems funky. Also speccing into Shuriken Toss shows a massive dps increase.

theherecy · 01/07/13, 8:50 PM

Using the auto reforge tool is consistently producing negative DPS results, using for a second time brings back the original reforges, and then back again.

Seems to be a little strange, not sure if there is any validation on the DPS output compared to the original DPS.

dinesh · 01/08/13, 9:27 AM

It's been explained repeatedly before (in this thread I believe), you're at an edge where two values are close to each other. Reforging once will take you from one stat to another, then the stat values are recalculated and change slightly, and now the first is more valuable again.

Vikken · 01/08/13, 1:33 PM

Please pardon me if this has been answered before, but what is the status and/or any caveats with the pvp mode? For instance, I notice that hit/expertise caps remain unchanged, and I am unclear as to what it exactly does. Does it assume a baseline armor/resilience? I'm working a basic pvp guide for the official forums and I would like to use shadowcraft to confirm some information out and SC is my goto tool. I recommend it a lot of the forums for pve.

I am just unclear about what exactly the mode does, and/or any caveats that need to be considered with using it for pvp.

Pathal · 01/08/13, 4:21 PM

The only thing that does right now (that I'm aware of) is start calculating the EP weight of PvP Power, and factor in the damage gained and lost from PvP stats.

metzli · 01/08/13, 4:46 PM

It doesn't actually cut off a flat 40% dps so there is likely some other coding going on there, or it just is not implemented as a blanket 40% dps loss. So either they know something I do not, or it just doesn't work out to be a linear conversion. Point being I don't think it'd be accurate to say you could just take X% off of the shadowcraft PVP mode dps to factor in average resilience.

Pathal · 01/08/13, 4:57 PM

That's because the engine is set to consider the target's PvP Resilience, which works by this: https://github.com/Indz/ShadowCraft-.../stats.py#L106

This is how the values come together: https://github.com/Indz/ShadowCraft-...init__.py#L568

metzli · 01/08/13, 5:12 PM

Should it not just return .4 if you have no resilience or pvp power though? That is not what I actually see in the numbers when I use it. I get a 35% damage reduction instead of a 40%....so maybe I am missing something. I guess things like anticipation and procs change damage in such a way that it does not receive a flat reduction.

Pathal · 01/08/13, 6:03 PM

That's what those formulas do.

1 - 0.99 ** ( rating / self.pvp_power_rating_conversion ) + .4 returns .4.
1 + rating / (100 * self.pvp_power_rating_conversion) returns 1.
1*(1-.4) = .6, so 60% of the original DPS.

I highly doubt there are any issues with the math in those formulas.

TxH2oSkier · 01/08/13, 6:48 PM

Not sure if someone missed my post but is there a reason why Shadowcraft doesn't recognize any Dominance Offensive items as an upgradable item even though they are?

Indz · 01/09/13, 5:03 AM

Sorry for no reply. I was aware of the issue. I had to update the item import method to now use the blizzard community api, which has for every item the correct value for upgradable. First I used the table from the WoW Client which isn't up-to-date. Not it should be all correct. If you load the site first time and you don't see your boots please try a reload from armory, but it should work immediately.
If there are other items missing please let me now.

Another Topic:
Are people out there who already used [Eye of the Black Prince]? Is there an achievement attached to it?

metzli · 01/09/13, 5:32 AM

I think this is what you're looking for indz.

Chapter II: Wrathion's War - Achievement - World of Warcraft

theherecy · 01/09/13, 1:00 PM

Originally Posted by dinesh

It's been explained repeatedly before (in this thread I believe), you're at an edge where two values are close to each other. Reforging once will take you from one stat to another, then the stat values are recalculated and change slightly, and now the first is more valuable again.

This is probably true and my post was not to muddy the waters. I'm only asking because if the DPS estimate is correct why would it even suggest a reforge that would negatively impact it.

If I understand how it works correctly it should just validate the output before it proceeds:

if (originaldps <= newdps)
{
 *existing code*
}
else
{
break;
}

• Aldriana · 01/09/13, 1:45 PM

Because the final number at the end isn't the only thing that matters. If there are multiple reforges close together in quality, some people want to know that. And those people that do only care about the biggest number can still easily retrieve it by re-selecting the pre-reforge gearset.