 |
01/14/08, 8:46 AM
|
#16
|
|
Don Flamenco
Draenei Paladin
Darkspear
|
Originally Posted by Dontmindme
Yeah, looks like of all the things I did (adding Macros, buttons, modifying code) the one thing that broke things was removing those dead rows in the middle of the gear sheet. I see the issue with Haste and -Armor AEP (same basic issue as with the Upgrade macro). I guess this could be quick fixed by inserting back in 3 columns in front of Column M running from Row 9 to Row 79. This would fix both the upgrade issue as well as the Haste and -Armor AEP. I'll have to go in and fix the macros for a more permanent solution.
...
|
Re-inserting those three columns in the Gear_Buffs sheet will affect the DPS calculations, so something isn't quite right. I imported my gear and I was getting 1278 DPS. Then, I reinserted the columns and my DPS dropped twice, ending up at 1207 DPS. After a bit of investigation, it seems that after re-inserting the three columns, the damage calcs are still somehow looking for Haste and -Armor in cells M78 and N78, respectively. Since these cells now contain 0's, but if I put the previous values in manually it works again.
EDIT: I figured it out. The grand totals are at the bottom of the buffs section, and they are simple column sums. Inserting three columns from row 9 to 79 only will misalign Haste and -Armor from gear in the bottom half of the sheet. Instead, you need to reinsert 3 columns from rows 9 to 141 (not 79), starting at column M. This should fix the macros and still preserve the correct calculations of summing Haste and -Armor from gear and buffs.
Last edited by Left : 01/14/08 at 8:51 AM.
Reason: Figured it out
|
|
|
|
|
01/14/08, 11:48 AM
|
#17
|
|
Von Kaiser
|
2 quick questions/notes on the spreadsheet:
1. I am using a Blinkstrike (*shakes fist at Tidewalker*) and the proc isn't modelled in the sheet. Not a problem, I just have to unhide the weapon sheet and add the proc info to the Blinkstrike entry (211, 1.7, 1 is what I use). On 2.3.2.8, the proc DPS does not seem to be carrying over to the Gear Buffs sheet- I make the changes and the proc DPS stays at 0.
2. Kind of in the same vein- is the proc from Hourglass of the Unraveller or Tsunami Talisman modelled in the sheet? It looks to me like they have a straight-up +32crit and +38crit +10hit bonus, respectively. From some rudimentary research it looks like the proc cooldown is 45sec. If you use a conservative estimate of 1.5ppm, that's a flat 33/38 AP which ranks the trinkets significantly higher than they are now. If that's already modelled somewhere then disregard, of course. 
|
|
|
|
|
01/14/08, 12:09 PM
|
#18
|
|
Piston Honda
Pandaren Rogue
Tarren Mill (EU)
|
I'd love it you added other cycles to dagger for comparatives, Mostly 1snd/3snd/5r and 1snd/3r
|
|
|
|
|
01/14/08, 3:59 PM
|
#19
|
|
Glass Joe
Night Elf Rogue
Shattered Hand
|
Thanks for all the work put into this tool!
I'm using the 2.3.2.8NA with OpenOffice 2.3 and noticed the following:
With the exception of chest gem sockets, the font color and background color for other items stays gray on gray. The drop down let's you select gems, and it is calculated correctly, the gem names just are not visible without changing the the color scheme.
|
|
|
|
|
01/14/08, 4:31 PM
|
#20
|
|
Glass Joe
|
Somehow this version is showing me that Talon of Azshara is a buffed upgrade to Blade of Infamy and that should clearly NOT be the case. I'm also seeing Stealther's Helm of Second Sight as an on-par upgrade to tier 6 helm? I saw that in the last version too and couldn't figure out what was going on, but it went away eventually so I never figured out what was happening and why that was possible. I'm wearing 4 pieces of tier 5 (everything but the chest) and only started occurring after I starting putting 4/5 tier 5 into the sheet.
Last, the upgrade selection box on the gear spreadsheet, no matter which option I chose, it's always showing me buffed and unbuffed upgrades. This is annoying because I really couldn't care less about unbuffed upgrades and don't even want to see them listed in the comment at all.
|
|
|
|
|
01/14/08, 5:01 PM
|
#21
|
|
King Hippo
|
For those with problems with the Meta Gems, are you all using Open Office? Or are you using Excel? This would help me track down what is happening. And, have you tried inserting 3 columns from Rows 9 to 141 just ahead of Column M? I'll get to the rest of the issues when I get home from work.
|
|
|
|
|
01/14/08, 7:47 PM
|
#22
|
|
Piston Honda
|
I use Excel 2007 with the latest updates.
I'll try re-downloading and futzing with it.
* UPDATE *
Re-downloaded the spreadsheet, shifted the columns right, reset the gear, then imported my data from the Armory and now the MetaGem activation color is correct.
Last edited by Furtim : 01/15/08 at 12:18 AM.
|
|
|
|
|
01/14/08, 8:12 PM
|
#23
|
|
King Hippo
|
Okay, so looking at issues in order...
1) Ashtongue Talisman of Lethality
Seems to be modeled correctly, except...
a) Somewhere along the line, someone decided that that the result seemed too high and nerfed it to 70% of it's calculated value. If I undo this nerf, it will be approximately 42.86% more dps than currently modeled. This doesn't seem very unreasonable comparing it to other trinkets. It currently seems rather undervalued, so I'm leaning to undoing the imposed nerf, but I'm open for comment.
b) The results are being added after the cycle module. The way it is currently being added should give a decent estimate of it's contribution nonetheless, but it will unfortunately not influence the suggested cycle. It will probably have to stay that way until I find time to integrate it's existence into the cycles themselves. Basically just an advisory to Seal Fate users that you might be able to drop down a cycle using it.
2) Haste, -Armor AEP and Gear Upgrade macro issues.
Inserting 3 columns of cells between Rows 9 and 141 just ahead of Column M (shifting cells to the right) fixes these issues.
3) Meta gem and gem cell coloring issues (Open Office)
Open Office seems to be doing something very very strange with Conditional Formatting. I see the problem opening it in Open Office and I still for the life of me cannot figure out why the Meta Gem is turning red. I doesn't do this with Excel (even if maybe it should be programmed to do so). For some strange reason, opening the same version in Excel where the Conditional Formatting is pointing to C##, in Open Office "some" of them are pointing to D## to look for whether to turn coloring on or not. I'll have to play around with it to see if I can get it to stop doing that.
4) Mac crash issue with the new pulldowns
Well, these new Macros shouldn't be doing anything that should break anything on the Mac. I'll be looking this over more closely. Unlike the MSXML issue with Armory import, these functions should be able to work on a Mac and given the usefulness of the feature, its a high priority.
5) Macs and Wow Armory
Yeah, honestly, it doesn't look good until MS decides to add that library. Now, given the weirdness with Open Office and some very basic Conditional Formatting, I'm having serious doubts about Open Office compatibility (and Macros are a big step further than ordinary spreadsheet features that Open Office supposedly should emulate). Now, I do know there are a couple Mac users looking into the issue a bit. If they find something, I'll explore it further.
6) Colored Sockets
It's something I've partially explored. I have a basic model to make it work (pretty easy actually) but if the socket order in items does not follow a standard pattern (and I believe I remember some weirdness), Armory Import will not be very compatible without a major rewrite of the item data system. It's on my to do list as part of the revamping of the Gear Buff sheet.
7) 2 Gear sets at once
Actually, with this new functionality (once I have it working on Macs). It shouldn't be too difficult to do that on the Item Compare page with the addition of a few Macros. Mac functionality comes first though.
8) Blankstrike, Hourglass, Tsunami
These are all actually modeled but they are added on the (Un)Buffed DPS pages. For example, Blinkstrike adds to extra MH Attacks as noted in Cell Q12. You will find Hourglass and Tsunami accounted for in the columns on those two sheets as well.
9) Additional cycles 1s/3r and 1s/3s/3r
They should probably be added, I agree. It's been on my want to do list for awhile, but I've been pushing it back in favor of other issues and upgrades. I'll try to give it a stab this time around, but if adding a couple rows breaks the cycle sheets (like removing 3 unused columns did) it will be pushed back some more.
10) Talon of Azshara vs. Blade of Infamy
I'm not so sure I'd call that clearly the case. Talon of Azshara has better non-weapon stats. The damage range is practically the same (so no difference on special attacks). The only difference is a small edge on white dps. It may be possible that Talon might be slightly better in some circumstances just from the extra hit rating.
11) Stealther's Helm of Second Sight
Yeah, that one's a bug. Looks like there is a minor bug with Armory Import regarding Meta-gem sockets. If you type "none" in the third gem socket (even if it's grey) the upgrade will work correctly again. Instead Stealther's is giving a N/A and apparently the upgrade macro is just copying the previous item's DPS when this occurs.
I can't give much of a timetable on fixes at this time, but I'll hope to have some of these fixed by this weekend. Adding these 3 columns back in will help many issues though.
Last edited by Dontmindme : 01/14/08 at 8:23 PM.
|
|
|
|
|
01/15/08, 6:14 AM
|
#24
|
|
Glass Joe
|
There seems to be an unreported issue with OH Proc DPS calculations?
If I select Thunderfury as an OH, it's proc type (5) should appear in AM23 on the weapons page. Instead it's reporting a weapon stat and killing the calculation.
I'm guessing this means that all weapons with proc DPS are being misrepresented.
I think this is due to the columns being shifted at some point, P-type was column W and is now AA.
|
|
|
|
|
01/15/08, 7:07 AM
|
#25
|
|
Piston Honda
Human Death Knight
Defias Brotherhood (EU)
|
Just a little note that the Metagem bug doesn't only apply to Armory importing. If I manually change from using my Netherblade Helm to the Grimgrin Faceguard the same thing happens and the same fix you just mentioned works, at least when using Openoffice.
|
|
|
|
|
01/15/08, 3:39 PM
|
#26
|
|
King Hippo
|
No, but because the Tier builds I used were imported from the Armory, it bugged the sheet up for any Helm that uses 3 sockets that doesn't have a Meta.
Late last night I figured out the resolution to a few issues:
Going back a few posts, I should have a new version out by the end of the week that includes the fixes for #2, #3 and #11.
Basically, I'll be adding those 3 columns back in.
Reformatting all the conditional formatting for Gems (re-doing it, fixes the issue with Open Office, still no idea why it currently works correctly in Excel but is different in OO with the exact same file...but anyway).
And I figured out how to adjust the Armory Import to avoid the 3rd Gem slot problem. The issue is a result of the Meta gem workaround. Whenever a helm is imported with a Metagem, it's leaving the 3rd gem slot blank instead of saying "none" which the spreadsheet wants (as the meta gem was moved to it's own spot). I just need to add a line that puts "none" in the correct place when it finds a Metagem. This has also propagated into the Default gear pulldowns and is an issue as the sheet is currently saved.
I hope to also make an adjustment to the new Macros to speed them up a bit. This *might* fix the Mac issue if the problem is a timeout issue. No guarantees.
I also took a quick look at adding new normal cycles into the spreadsheet. It looked promising, didn't seem to break anything, so I plan to add a number of them in the next major release (not the bug fix release) including a lot more 4e and 4r cycles which should be helpful to non-Mutilate Seal Fate builds (as well as the 2-pc T4 short dagger cycles).
Just an FYI, it will be at least until Wednesday before I can put the bug fix release together.
|
|
|
|
|
01/15/08, 5:57 PM
|
#27
|
|
King Hippo
|
Also, in terms of the new pulldowns and saved Talent/Gear/Options/Buffs features, I need to know if this is working on any Macs. Please post or PM me if they *are* working for you. Also include the version of Excel and which OS you are using. I need to know if this is an isolated issue, an issue specific to certain OS's or Excel versions. So far I have one report of it crashing on OS X with Excel 2004 for Mac.
|
|
|
|
|
01/15/08, 5:59 PM
|
#28
|
|
Glass Joe
|
Messenger of Fate
It appears the dagger Messenger of Fate is tied to the Reputation check box. Meaning, it won't appear in the drop down list unless the Reputation box is checked under Equip Options. It should be tied to the Black Temple list. 
|
|
|
|
|
01/16/08, 3:21 AM
|
#29
|
|
Piston Honda
Dwarf Rogue
Proudmoore (EU)
|
Since quite some amount of rogues use the feral PVP.-bracers it might be a good idea to include them in the sheet?
Vindicator's Dragonhide Bracers (ItemID: 33881)
|
|
|
|
|
01/16/08, 5:04 AM
|
#30
|
|
Von Kaiser
Human Death Knight
Frostmane (EU)
|
ImageShack - Hosting :: compjg9.jpg
Some unconfirmed 2.4 items (Sunwell), don't know if you want to add them now or wait until 2.4 is released and add it in that version and make sure they got the correct stats instead of changing it twice :P
|
|
|
|
|
|