Elitist Jerks
Register
Blogs
Forums


Go Back   Elitist Jerks » Class Mechanics » Rogues

Closed Thread
 
LinkBack Thread Tools
Old 06/21/10, 10:23 AM   #256
dedmonwakeen
Bald Bull
 
dedmonwakeen
Undead Priest
 
No WoW Account
Originally Posted by Malkom72 View Post
How I can delete Rupture into the combat cycle ??

Where I can find the line : "rupture,if=buff.combo_points.stack>=4&target.time_to_die>15&time>10&buff.slice_and_d ice.remains>11" to delete it ??
From the GUI: When you Import a character from the Armory or from Wowhead, it moves you to Simulate tab where you will see a wall of text. Included here will be a talent link, a list of glyphs, a list of gear, and a list of lines that start "actions+=".

Comment out the line of interest by inserting a '#' character at the beginning of the line.


Offline
Old 06/29/10, 8:28 AM   #257
Brone
Glass Joe
 
Undead Rogue
 
Warsong
I was looking at the sample output on the Simcraft web-site and found something that I couldn't explain. Take a look, for example, at the wowhead profile of the T10 20/51/0 Patchwerk rogue. His gear does not match the BIS gear generated by the Loot Ranking that is generated from the scaling factors for that simulation. Also, his gemming does not match the same scale factors. Does this mean that this "BIS" rogue is actually many iterations away from optimal?

Offline
Old 06/29/10, 9:58 PM   #258
dedmonwakeen
Bald Bull
 
dedmonwakeen
Undead Priest
 
No WoW Account
Originally Posted by Brone View Post
I was looking at the sample output on the Simcraft web-site and found something that I couldn't explain. Take a look, for example, at the wowhead profile of the T10 20/51/0 Patchwerk rogue. His gear does not match the BIS gear generated by the Loot Ranking that is generated from the scaling factors for that simulation. Also, his gemming does not match the same scale factors. Does this mean that this "BIS" rogue is actually many iterations away from optimal?
While the results (scale factors, etc) are static, the loot links are dynamic.

The wowhead profile is quite old..... but gear discovery in-game has marched on relentlessly.


Offline
Old 07/09/10, 2:55 AM   #259
shaibatach
Glass Joe
 
Goblin Rogue
 
Blackmoore (EU)
Originally Posted by Brone View Post
I was looking at the sample output on the Simcraft web-site and found something that I couldn't explain. Take a look, for example, at the wowhead profile of the T10 20/51/0 Patchwerk rogue. His gear does not match the BIS gear generated by the Loot Ranking that is generated from the scaling factors for that simulation. Also, his gemming does not match the same scale factors. Does this mean that this "BIS" rogue is actually many iterations away from optimal?
It simply means, that this isn't meant to be a BiS profile.

Germany Offline
Old 07/29/10, 1:06 AM   #260
Brone
Glass Joe
 
Undead Rogue
 
Warsong
Envenom/Mutilate Crit Chance

I've been banging my head on my desk for 3 hours now trying to figure out why the crit rate for envenom in my SimulationCraft logs does not match the crit rate of my white hits, and the crit rate for Mutilate does not equal my white crit rate + 15%.

The white crit rate is EXACTLY as it should be (tooltip melee_crit_rate + 3%_Master_Poisoner_buff) and my poison crit rate is exactly correct (tooltip spell_crit_rate + 3%_Master_Poisoner_buff) but my envenoms crit roughly 2% less than my white hits. And my mutilates crit only 12% more than my white hits (instead of 15% from the Puncturing Wounds talent).

I'm assuming it's not a bug and that I am missing something like a talent or the way Blizzard adds percentages but I can't figure out what it is.
I disabled cold blood in the simulation; that was modifying the envenom crit rate in the other direction. Also, I have no crit proc gear.
I ran 100 second fights, 500 second fights, and 5000 second fights, all for 5000+ iterations, and was getting basically the same result.

By the way I am in love with this tool. I discovered the target_resilience parameter today which made me very happy...

-Brone

Offline
Old 07/30/10, 1:11 PM   #261
Brone
Glass Joe
 
Undead Rogue
 
Warsong
Well, I believe I have resolved the issue. It looks like SimulationCraft is using a 2 roll structure to evaluate special attacks, where the first roll decides whether the attack is a crit, and the second roll decides whether the mob dodges the attack. The toon that I was simming had 0 expertise, and thus was being dodged 5% of the time (against a lvl 80 mob). Roughly half of those dodges were consuming a crit determined on the previous roll, thus leading to my lower than expected crit rate.

I looked up the two-roll theory on Wowwiki and noticed that it claims that crits are evaluated on the SECOND roll. So is Wowwiki wrong or SimulationCraft wrong?

-Brone

Offline
Old 07/30/10, 1:27 PM   #262
• Aldriana
Mike Tyson
 
Night Elf Rogue
 
Doomhammer
Short answer is that it doesn't actually matter which is which. Consider:

For simplicity, lets say our crit rate is 50% and our miss/dodge rate is 10%. If we do the miss/dodge roll first, we then get 90% hits and 10% dodges; then half of those 90% that hit crit, so we get 45% crit, 45% regular hit, and 10% dodge.

If, on the other hand, we do the crit roll first, we get 50% crit and 50% hits, and then 10% of each miss, leaving us with... 45% crit, 45% regular hit, and 10% dodge.

Hence: they're both right, and are saying the same thing. You can think about it in either order, and the math works out.

Offline
Old 08/07/10, 11:17 PM   #263
Anthropology
Glass Joe
 
Orc Warlock
 
Vek'nilash
Originally Posted by dedmonwakeen View Post
From the GUI: When you Import a character from the Armory or from Wowhead, it moves you to Simulate tab where you will see a wall of text. Included here will be a talent link, a list of glyphs, a list of gear, and a list of lines that start "actions+=".

Comment out the line of interest by inserting a '#' character at the beginning of the line.
I got very strange results with this, and found that deleting "&dot.rupture.remains" from two of the eviscerate lines brought the DPS much closer to that of rupture cycle simulations.

Offline
Old 08/08/10, 6:52 PM   #264
dedmonwakeen
Bald Bull
 
dedmonwakeen
Undead Priest
 
No WoW Account
Originally Posted by Anthropology View Post
I got very strange results with this, and found that deleting "&dot.rupture.remains" from two of the eviscerate lines brought the DPS much closer to that of rupture cycle simulations.
Excellent point. I had not considered that the Rogue action pseudo-AI had rupture-related conditionals on the eviscerate logic.


Offline
Old 09/29/10, 4:23 AM   #265
Brone
Glass Joe
 
Undead Rogue
 
Warsong
HAT Variables

What is the difference between the variables 'hat_donor' and 'honor_among_thieves' in SimulationCraft? They are both listed as procs.

I am running a simulation with only 1 person (myself). hat_donor seems to correctly list the number of HAT procs under the Count column, when I am specced 3/3 in HAT. However, if I go 1/3 or 2/3, the count doesn't seem to get reduced correctly. Alternatively, the honor_among_thieves variable count seems too high to represent the number of HAT procs. I have tried really hard to figure this out on my own and haven't been able to. In the source code it reads as if hat_donor counts the number of specials and honor_among_thieves counts the number of HAT procs but that is not what I am seeing.

Offline
Old 09/29/10, 5:29 AM   #266
todemax
Piston Honda
 
Troll Rogue
 
Zenedar (EU)
There's a one second cd on HaT procs. So hat_donor would be the abilities that actually can proc HaT. And as far as I can see the honor_among_thieves variable is used to track the one second cooldown. The 1/3 chance of proccing HaT with 1/3 points are included in the rng to determine if a combo point is gained and not in the hat_donor.

Offline
Old 09/30/10, 3:54 PM   #267
dedmonwakeen
Bald Bull
 
dedmonwakeen
Undead Priest
 
No WoW Account
Originally Posted by Brone View Post
What is the difference between the variables 'hat_donor' and 'honor_among_thieves' in SimulationCraft? They are both listed as procs.

I am running a simulation with only 1 person (myself). hat_donor seems to correctly list the number of HAT procs under the Count column, when I am specced 3/3 in HAT. However, if I go 1/3 or 2/3, the count doesn't seem to get reduced correctly. Alternatively, the honor_among_thieves variable count seems too high to represent the number of HAT procs. I have tried really hard to figure this out on my own and haven't been able to. In the source code it reads as if hat_donor counts the number of specials and honor_among_thieves counts the number of HAT procs but that is not what I am seeing.
Looks like the code simply checks for the existence of that HAT talent without actually looking at the number of ranks. This is a bug. Please open an Issue on the site.

Note that "hat_donor" refers to the actor generating HAT procs for Rogues in his party. In single-player sims, the option "critical_strike_intervals=A/B/C/D" represent average intervals between critical strikes for four "virtual" players. If you run with multiple players and put them in the same party, then the "critical_strike_intervals" option is ignored and the Rogue receives HAT procs from his party members.


Offline
Old 10/01/10, 4:31 AM   #268
todemax
Piston Honda
 
Troll Rogue
 
Zenedar (EU)
Doesn't
if ( ! rogue -> rng_honor_among_thieves -> roll( rogue -> talents.honor_among_thieves / 3.0 ) ) return;

    add_combo_point( rogue );
check for the ranks in HaT?

Offline
Old 10/01/10, 11:39 PM   #269
dedmonwakeen
Bald Bull
 
dedmonwakeen
Undead Priest
 
No WoW Account
Originally Posted by todemax View Post
Doesn't
if ( ! rogue -> rng_honor_among_thieves -> roll( rogue -> talents.honor_among_thieves / 3.0 ) ) return;

    add_combo_point( rogue );
check for the ranks in HaT?
Argh.... Yes. That code still gets triggered even with critical_strike_intervals.

I have no explanation then. I'll have to exercise the code before I make any more snap judgements.


Offline
Closed Thread

Go Back   Elitist Jerks » Class Mechanics » Rogues

Thread Tools

Similar Threads
Thread Thread Starter Forum Replies Last Post
SimulationCraft Model Development dedmonwakeen Public Discussion 616 02/22/13 10:01 AM
SimulationCraft: Multi-Player Sim for WotLK dedmonwakeen Class Mechanics 4 07/26/08 7:52 AM
From TheoryCraft to SimulationCraft dedmonwakeen Class Mechanics 18 06/09/07 5:03 PM