I was investigating an issue reported by inconsistencies in Rawr.Enhance & EnhSim with
[Talisman of Volatile Power] now it turns out there were bugs in both programs. It did throw up an interesting issue what precisely constitutes "spell damage" and "spell casts" as far as special effect triggers are concerned. A special effect trigger is something that initiates a proc - eg: Set bonus LL triggering Quaking Earth, or spell cast triggering trinket.
Currently EnhSim has the following definition for spell cast...
public pShockCast,
public pLightningBoltCast,
public pLightningOverloadCast,
public pChainLightningCast,
public pLavaBurstCast,
public pLightningShieldCast,
public pFireNovaCast
Now I note no mention of things like magma totem drops which are spell casts, and apparently do trigger the talisman shouldn't these be included?
We also have the related Spell Damage...
public pShockDamage,
public pLightningBoltDamage,
public pLightningOverloadDamage,
public pChainLightningDamage,
public pLavaBurstDamage,
public pFireNovaDamage,
public pLightningShieldDamage
The sim has no concept of separating non periodic damage, periodic damage and spell damage. I suspect we should make a separation between them. So that we can have effects proc on any spell damage (including periodic damage such as FS Dot ticks and Magma/searing totem pulses), periodic damage (FS Dot ticks and magma/searing totem) and non-periodic damage (as above).
I may be wrong but doesn't most trinkets that proc off spell damage also proc off magma totem damage & FS Dot ticks?
Whilst I'm musing on these things, where does Flametongue weapon imbue damage come into this? Should it be treated as spell damage? Does it proc things that come under the spell damage list? If so then the Sim is ignoring this source of spell damage at present.