[Enhancement] Rawr.Enhance thread - Page 10

andreasg · 05/06/09, 10:50 AM

Originally Posted by Levva

Whilst I appreciate the desire to help. Running EP calcs in either program is going to be very very meaningless. What I need is the simulated DPS figures not EP values as EP doesn't tell you what the source of the damage is ie: what ability does what.

Sorry about it, here's the DPS figures for EnhSim and Rawr:
Calamity's Grasp:
EnhSim 3437 DPS
Rawr 3317 DPS Points

Wraith Strike:
EnhSim 3449 DPS
Rawr 3366 DPS Points

Golden Saronite Dragon:
EnhSim 3474 DPS
Rawr 3360 DPS Points

As you can see EnhSim rates GSD > WS, while Rawr rates WS > GSD.

Tell me if there's anything else you need, like my armory profile, for example.

Originally Posted by Levva

NO its not going to happen for numerous reasons. First and foremost there are plenty of options in EnhSim that are nothing to do with Rawr. Such as simulation time, EP weights etc (Rawr doesn't use EP values at all - its a common misconception that Rawr does its calculations by using EP weights).

To store all those options would need basically to replicate all of EnhSimGUI which is a LOT of additional and completely unnecessary work. Some have suggested replacing EnhSimGUI with Rawr would then make it easier however that would then make using EnhSim dependant on Rawr. EnhSim is a separate standalone project with a sole developer in charge, Rawr is a large project which I am but one developer on. I have only a small say in when a new release comes out, so I can't update Rawr and have it ready when a new version of EnhSim is ready. Basically I cannot try to turn Rawr into a GUI front end for EnhSim and have no wish to do so.

Rawr is an entirely standalone program and my goal is to have it give reasonably accurate results within the confines of a closed form solution. A simulator will always give more accurate results for those that need them and so the two button click approach to export your stats really is easy. I cannot see how you can possibly complain that clicking two buttons "gets old fast" you must have an exceptionally low boredom threshold.

I know a lot of people suggested merging the two programs, and that is not what I suggested, and I agree, it is completely unrealistic. Furthermore I can completely understand if there are things that you do not want to do or can't. I'm the author of a unit frame addon that's been around for a good time, with both good and bad suggestions coming in, so I think I might have an idea of how it is.

The thing I suggested essentially doesn't amount to more than merging/outputting a text file (config.txt) instead of saving it to the clipboard. This means the user could just run the EnhSim program right after clicking export, instead of having to edit text files. But don't take it for more than it is, just a friendly suggestion for an application I love. No hard feelings if you do not feel it is necessary. I'm sorry about the boredom comment, it was more about creating a more efficient workflow.

Levva · 05/07/09, 9:32 AM

Originally Posted by andreasg

Tell me if there's anything else you need, like my armory profile, for example.

Actual dps breakdown by ability is really what I need, cut n' paste from EnhSim output.txt and cut n' paste from Rawr (copy data to clipboard NB. NOT copy EnhSim config to clipboard). This quickly and simply gives the two exports. I'd hang off though as I committed a couple of big bug fixes in last few days. This included where it was erroneously exporting 4.8% extra melee crit in the EnhSim config thus inflating melee crit rates in the Sim. Also I found that I was not including boss fire & nature resistance (the 2.8175% base kind) which will reduce spell based dps, and a few other tweaks.

A new version should be out in next few days.

Originally Posted by andreasg

I know a lot of people suggested merging the two programs, and that is not what I suggested, and I agree, it is completely unrealistic. Furthermore I can completely understand if there are things that you do not want to do or can't. I'm the author of a unit frame addon that's been around for a good time, with both good and bad suggestions coming in, so I think I might have an idea of how it is.

The thing I suggested essentially doesn't amount to more than merging/outputting a text file (config.txt) instead of saving it to the clipboard. This means the user could just run the EnhSim program right after clicking export, instead of having to edit text files. But don't take it for more than it is, just a friendly suggestion for an application I love. No hard feelings if you do not feel it is necessary. I'm sorry about the boredom comment, it was more about creating a more efficient workflow.

The big problem with writing to a file is dealing with file permissions and thus having to deal with all the system errors that get thrown up by .NET for various reasons. This is typically not a big issue on XP but on Vista it gets a pain if you attempt to write to another programs directory. ie: you need to know where that directory is, do you have permissions, etc. All sorts of failures to be trapped waiting to be dealt with.

You cannot possibly just inject stuff into an existing file on disk, as that has all sorts of bad security connotations. Also from a programming perspective there are all the issues of deleting the old stuff you don't need any more in a file you're not sure what version it is etc etc. Add to that the issues with users having config files already open in text editor and possible file locks.

It would also mean that in Rawr you would need to popup a save dialog box and have the user click save (even if its the default directory) (two clicks) and in EnhSimGUI you'd need to do a file load and select the file (3 clicks) before you get to click Simulate.

So... file security headaches, working out what to delete and replace headaches, file locking headaches, extra user clicks and more complicated processing headaches...all in all two button click cut n' paste is dramatically simpler.

ankasunamore · 05/07/09, 11:56 PM

Just a quick question: Does Rawr work out the proc value of the DMC:G deck? Its pretty far down the list for my toon, apparently surpassed numerous other trinkets i would never think about equipping. On the tool tip it just says Greatness Proc.

Thanks for any info, or if i done something wrong. (v.2.2.2)

Sengiratolom · 05/08/09, 2:32 AM

I removed the "greatness proc" line from DMC on rawr and simply changed it to 190 agility, that way its average value is shown and easyer to compare.

Levva · 05/08/09, 7:41 AM

Originally Posted by ankasunamore

Just a quick question: Does Rawr work out the proc value of the DMC:G deck? Its pretty far down the list for my toon, apparently surpassed numerous other trinkets i would never think about equipping. On the tool tip it just says Greatness Proc.

Thanks for any info, or if i done something wrong. (v.2.2.2)

That one's got caught up in the change from different special effects to a unified special effects class. I'd thought it was converted but I'll need to check again.

BigZ · 05/08/09, 10:28 AM

I am noticing that the simulator really wants me to keep my hit rating at 420+ and wants to take spell power over attack power. I realize it is all dependent on you gear, but are there some base algorithms that prioritize these stats? For example, the simulator continually likes Sundial of the Exiled over Fury of the Five Flights by about 38.4 dps. They are ranked about 14 items apart, so it is a pretty significant gain on the sim.

OnosKT · 05/08/09, 10:42 AM

I am noticing that the simulator really wants me to keep my hit rating at 420+ and wants to take spell power over attack power.

Are you selecting the +hit debuff (misery/imp moonkin?)

The SP > AP is a known issue and Levva is working on it.

BigZ · 05/08/09, 10:50 AM

That did indeed change the results for hit.

Sylvand · 05/10/09, 9:08 PM

Sorry if this is already reported, but I could not find it in this thread. I just encountered an issue where the export to enhsim includes the 2% spell crit from the Flametongue glyph, but enhsim expects the spell crit to not include this value.

It confused me for a minute because selecting Feral Spirit glyph in rawr and exporting would show a dps loss, while making the change in enhsimgui shows a dps gain instead.

Levva · 05/12/09, 9:30 AM

Originally Posted by Sylvand

Sorry if this is already reported, but I could not find it in this thread. I just encountered an issue where the export to enhsim includes the 2% spell crit from the Flametongue glyph, but enhsim expects the spell crit to not include this value.

It confused me for a minute because selecting Feral Spirit glyph in rawr and exporting would show a dps loss, while making the change in enhsimgui shows a dps gain instead.

Yeah this is fixed for v2.2.3 (not released yet) If you want to get the latest version you can download it from the MMO Champion Thread I maintain, that should always have the latest Rawr.Enhance model if there is a newer test version I've done.

Rawr.Enhance - Enhancement Shaman DPS calculator

Levva · 05/13/09, 1:28 PM

Public Release of v2.2.3

The list of changes from v2.2.2 is below. I was in the middle of trying to get stuff checked and squeezing last minute changes trying to make sure they got into this release so there is a few last minute bits not fully checked. As I have one significant change that missed the release. However it was the one I was least confident was right and so its probably good it missed the cutoff, as really it needs a lot of testing.

I'm seeing Hit rating unusually highly favoured in this release, and still not quite got to the bottom of spellpower favouritism although the last change I was working on has the potential to have a major impact for v2.2.4 as it deals with how much damage normal vs crit spell abilities do. I suspect the core issue is to do with two roll spell damage models vs how much hit/crit you have.

Changelog - Version 2.2.3
Change crit multipliers for meta gems
Various SP/AP fixes when buffs ticked
Export to EnhSim revamped and code simplified - shouldn't directly impact users just makes future updates to code easier
Added RelevantTrigger function to filter special effects
Split each ability into Normal & Crit dps for ease of checking errors
New proc evaluation mode: Advanced - Interpolation - check this is set in your Options panel please
Implemented BaseStats Class in Rawr.Enhance
Added MH & OH weapon speed custom charts
Fix missing SP from AP gained with UR
Fix display issue on damage percentage for Lightning Shield
Fix crit export to EnhSim after previous mucking around with crit depressions.
Added an over spell hit cap warning to stats frame.
Apply crit depressions uniformly
Fixed Lava Lash & Stormstrike shouldn't have benefited from weapon mastery
Allow Feral Spirits to benefit from Shaman's Unleashed Rage uptime buff if talented.
Applied Math Floor float fix.
Fix cut n paste bug that applied miss rate to overall Spirit Wolf dps.
Plus base feral spirit damage was not taking their base speed into account thus their dps was only 2/3rds of what it should be.
Fix for double counting of whiteCritDepression
Add in effects of default boss Fire & Nature resistance
Now that Armoury import imports glyphs no need to set glyph defaults.
Added triggers for Shaman Totem relic slot items and implemented Totem of the Elemental Plane
Fix for combat table (white) display showing old glancing blow value (display issue only)

BigZ · 05/13/09, 2:01 PM

I just downloaded and ran 2.2.3 ran the sim and see the favortism to hit. Is there any work around that can be done in that version or way to manually adjust? Or is it best to just continue to run 2.2.2 for now to get more accurate results?

Extenze · 05/13/09, 7:07 PM

I just ran the optimizer, and it's giving me 538hit rating fully raid buffed, and putting me under expertise cap. I'm also having an issue with the Furious and Deadly totems showing up in the ranged menus. They're being imported from wowhead/armory.

[e] It's showing the Glyph of Feral Spirits being #2 and 28dps points higher than WF, also.

OnosKT · 05/13/09, 8:10 PM

It's showing the Glyph of Feral Spirits being #2 and 28dps points higher than WF, also.

That is actually correct, every time I simmed it FS is better than WF. Our glyphs (see the glyph thread also) seem to be SS > FS (feral spirits) > WF at the moment.

Levva · 05/14/09, 4:08 PM

Version 2.2.4 - New General Release
Fix for PPMs of various weapon enchants
Fix combat table displays and add Combat Stats (Spell) display
EnhSim Export now supports the following combat options : combat_length, flask_elixir, guardian_elixir, bloodlust_casters, potion, food (will need new EnhSimGUI to import them though).
Moved all the combat stats modifiers into combatstats class to simplify calculation code
Changed Potion of Speed to use Special Effect
Added support for extra potions all using SpecialEffects with Use Trigger
Fixed a bug that would not allow item lists of gems.
Corrected only show top X gemmings, it was incorrectly showing the bottom X gemmings instead.
Removed the deprecated stats MongooseProc, ExecutionerProc, and BerserkingProc - Now modelled by SpecialEffect class

Note

I've done a massive amount of refactoring and simplification of the code in last few days between v2.2.2 and v2.2.4 during that time something has gone funny with hit rating in that it now seems as it if isn't capping. Now that the changes have been done I'll have some time to actually work out why this is. Apologies in the mean time for this inaccuracy. I'm also homing in on the spell damage being always 10% higher in Rawr than in EnhSim.

It made sense to hack the code about first to get it far cleaner and simpler before trying to fix the issue as its a lot easier to maintain now. This is largely because the prior incarnation still had a lot of crap to do with dealing with the old method of averaging trinket procs that just didn't work with EnhSim export. So when I initially wrote the EnhSim Export I had to put in a few hoops to jump through to fix that problem. Now we have changed to an on proc model and things are dramatically improved I can remove the hoops and make the whole code more streamlined. I hope this will make it easier for me to track down the source of the problem.

What I suspect is that the Average AP & Average SP calcs are generating too much AP & SP which shifts the balance. What I really need is to know what the average AP & average SP figures used by EnhSim are unfortunately this requires modifying the EnhSim code.