[Elemental] Lava Burst Testing
 

I'm getting slightly tired of the drama surrounding Lava Burst at the moment, so I want to do some testing. This is to make sure that we know exactly how Lava Burst works, and can apply that information to see if this has any relation to the "decrease" in DPS some have observed since 3.1 was released.

In this testing, we will need to test the following

1. Glyph of Lava - confirm exactly how it works
2. T7 4pc - Is it adding 10% to the crit modifier like we expect, or doing something else?
3. Crit multipliers - are they working exactly how we expect?
4. Co-Efficient - make sure it's correct
5. Damage gain talents - make sure Concussion/Call of Flame stack additively

These tests will need to following these conditions:

1. Elemental Oath cannot be present when LvB is cast. Either setup a cancel aura macro, or respec to be without the talent
2. Temporary buffs like trinket procs, elemental mastery, totems, auras, etc should not be present/used.
3. Accurate recording of spellpower figures, talent builds and glyphs need to be noted, as well as whether you have CSD or not
4. Combat logs should be submitted with the following names: [Test subject][Name][Date] and separated into With/Without sections in the text file
5. Samples need to have at least 50 hits, and 50 crits (this will allow for better statistical confidence in results, and also more information for testing crit multipliers) for each test (this will result in 200 casts per test). Obviously you can use FS to improve the amount of crit casts later in the test.
6. Also note whether you have Dual Spec enabled or not

This is mostly due to the comments seen here
Once we've made sure that Lava Burst works how we expect, we can take a look at Clearcasting, Flame Shock, and finally Lightning Bolt (and the T8 4pc bonus)

You probably want to specify which target dummy to test it on for consistency, and to make sure that any external buffs from other players are not present at the time.

Personally I am 99.9% sure that these tests will not find anything wrong, at least in terms of mechanics, and the max crit obtainable. Credit to you for suggesting a decent methodology, but I just don't think whatever problem there may be is going to show itself at a target dummy. Myself and Tufy have both tested LvB on dummies and found it to be fine, and then got suspiciously low crits when actually raiding.

Anyway, no argument that this is the right way to go about things, and I hope I am wrong, and that there is a bug thats fairly easily identifiable in this way.

This is more for establishing a baseline so that when one of those "suspiciously low crits" occur, we can look at it and say "ok, based on stats/buffs I would have expected X, but I got Y instead" and we can look at where they occur (is is some boss mechanic, dual spec bug, or something else?) and try to figure out why they occur. Then we can take the information to Blizzard and say "We've confirmed odd behaviour under these conditions".

The alternative to this is that everybody just shuts up about "my lava burst crits are low", because if you don't want to help test & confirm the problem, there's really no point in continuing to complain, is there?

I have spent rather a large amount of time trying to put this point of view across on the EU forums, and had a fairly predictable response. I probably should have known better.

Personally, having spent a considerable time testing LvB in the past, and several hours testing it again after 3.1, I am both reluctant to spend any more time on it, and personally convinced that there are not any problems to be found from target dummy testing. Of course, I am just one person with my opinion, hopefully there are lots of willing volunteers to go out, do some tests and prove me wrong.

If I may suggest, this thread could also be used in parallel to forensically pick over any "dodgy" LvB crits from actual raiding environment? And I don't just mean anything thats "a bit low", I mean something identifiably below where it should be, from a player who understands the generally assumed mechanics of the spell, and has a combatlog to back it up. I realise this is slightly getting ahead of ourselves, but as LvB is not a new spell, and everyone who has looked so far hasn't found any hard evidence its mechanics have changed (including assurances from Blizzard who checked their change logs etc), would it not also be useful to look at actual data?

Other than the 2 damage increasing raid buffs, special boss mechanics, and any spellpower increase caused by a Demo lock in excess of ToW, I can't think of any other variables that should exist outside of an actual bug. If accurate details were given of spellpower, trinkets etc. at the time, this would have at least half a chance to find something.

I do realise the base mechanics of the spell need to be tested in time to prove anything, and do not wish to discourage anyone from doing that.

Been busy today doing the test in parts since I didn't have enough time to test all the parameters, will update this post with logs tomorrow.

I agree with Mmootimus, I have only encountered questionable numbers in raids so far and not on dummy's.
However, while testing for possible differences from the assumed mechanics you need a base to build your assumptions on. So I hope more people are willing to spend some time to get some logs.

Edit:
been completely swamped this weekend, so a tad slow ;( first 3

Log 1 to 3

1.

2174 Spell dmg
no Lava flows
No Lava Glyph
no Meta
No 4 set

spec; Talent Calculator - World of Warcraft

2.

2350 sp

Lava flows
Lava glyph
meta Gem active
no 4 set

Spec; Talent Calculator - World of Warcraft

3.
2350 sp
No lava flows
Lava glyph
Meta gem active
no 4 set

Talent Calculator - World of Warcraft

I think both methodologies are valuable. Let’s, once and for all, check the baseline functioning on the target dummies (I would suggest a level 80 dummy to avoid misses as people won’t have the +3% raid buff). At the same time let’s start gathering raid combat log data. Not I hasten to add, unsupported comments that I did a 6XXX Lava Burst and should have done more, but WWS reports or the like where we can check what debuffs were on the boss and what buffs were on the player at the exact time the spell was cast/landed.

Mmootimus – do you have any data saved for the tests you have done so me might use those as part of our baseline? I'll get my data together tomorrow and add it to the thread.

I applaud the effort - it's very important to be sure of how the mechanics work before you can look for possible bugs. I will attempt to get some logs as soon as possible on the dummies. Binkenstein, which dummy did you want us to use, heroic or boss?

I started to hear of this "low crits" problem some time ago, but never really thought much of it, didn't feel like I was having any problem with my Lava Bursts. But today on Ignis, I had ~4k SP (trinket procs) and my LvB crit for just 10k. This was in the heat of the moment, so I didn't really check if there was a reason to it, like partial resist or even missing CoE, but my LvB had generally seemed low the whole raid.

Recently, I've been working on this addon here. In it, I've added some debug code to it which will calculate the expected damage range a spell should hit for, and then report if the actual spell hit outside this range. Could be interesting to turn this debug code on during a raid, just to see if there are any problems.

Heroic. Eliminates miss and resists affecting results.
That seems awfully similar to DrDamage.

As I've said, once we establish the base mechanics, we should be able to reliably predict how LvB scales with % gains and extra spellpower. This means that if someone goes "I had X sp (minimum) for this fight, and got crits for Y, what's going on?" we can easily calculate what the base damage should be, multiply it out for crits, and then see how close this comes to the observed figures. It may be that these are all products of ClearCasting not being up when Ebon Plague/Curse of Elements/Earth & Moon happen to be down, along with everyone switching from Glyph of Lava to Glyph of Totem of Wrath.

If you don't want to help with this, so be it. I'm not forcing anyone to, and I will try to do my own testing (I don't have dual specs though, and I don't see any problems myself, so I'll probably just end up confirming mechanics), but I think it would be fair to say if you don't want to participate in identifying what the "problem" actually is, you should stop complaining about said "problem".

Wouldn't you think the level 80 "Grandmaster's Training Dummy" would produce more accurate results to account for solo hit percentages without +hit debuffs that would normally be on a Boss level mob/dummy?

And also I'd love to lend my assistance in this research but I've never uploaded combat logs before. Could anyone give me a quick "How -To" on what site I could use that allows hosting of Training Dummy combat logs?

Yes, that is the one I mean.

Thinking simply, if people are only seeing problems with Lava Burst crits (it always crits). It would be logically to assume that you are fighting bosses with a certain amount of fire resistance.

I was actually discussing this bug tonight in my guilds caster channel and cheking the numbers in recount all night intentionally not putting up FS to check crit vs non-crit numbers. I was pointing out to fellow casters that I'd see 67k non-crit LvB's and 8-9k crit LvB's on the same mobs. To rule out Fire Resist it was on mobs from every corner of Ulduar. I also lead PuG Naxx25's with friends and guildies to get alts gear and I notice the same ranges there on its damage.

Anyways my money's on one of the crit modifiers of Lava Burst. If it crits for as much as it hits for, or at least it does for me. I also bought dual spec late as I really had no reason to have it since I only play Ele. I was noticing the same problem with and without having dual spec enabled.

Another point of interest before I get to bed... I was sitting at a training dummy for about 5 minutes as I didn't have time to do full tests with variables tonight and decided to shoot of a few Rank 1 LvB's. I got an 8100 crit with Rank 1. Immediately after I shot a Rank 2 and got a 7800 crit. Would it be worth anything to bother with Rank 1 v Rank 2 to verify base damages?

Did some testing with some spare time I had this morning.
All gear should be the same as listed in my armory, no weapon buffs or totems down and I cancelaura'd every trinket proc and elemental mastery.

6.7k is within the expected range of LvB hits assuming 2 trinket procs, EO/CC up and fully buffed/debuffed. 8-9k is within the minimum range of LvB assuming no trinket procs, no EO/CC and a debuff or 2 missing on the mob. This is why any such evidence should be supported by a WWS report or the like so we can see if there is something amiss or if it is just a combination of factors.

Rank 1 max base damage = 1290
Rank 2 min base damage = 1192

So it is quite possible for Rank 1 to crit for more than a rank 2.

Addressing an early point concerning Fire resist - I imagine we would have seen a little bit of fuss from the Fire mages if that had been the cause. As we have seen none, I think it can probably be discounted unless we have firm evidence.