Elitist Jerks
Register
Blogs
Forums


Go Back   Elitist Jerks » Class Mechanics » Shamans

Closed Thread
 
LinkBack Thread Tools
Old 01/12/10, 11:48 AM   #16
Rouncer
Deeper Shade of Blue
 
Rouncer's Avatar
 
Orc Shaman
 
Mal'Ganis
Originally Posted by Nevets_69 View Post
Sorry for double post, Rouncer posted while I was typing.

Rawr actually adds a portion of Elemental Devastation to the displayed crit chance, it's based on the calculated uptime for ED. I believe that it does that same with trinket procs, but I need to check this.

Unfortunately this is misleading when looking at the crit cap, since it won't tell you that you're wasting 1% crit while ED is proc'd, since it only adds a portion corresponding to the uptime (usually in 75% area). So 0.75*9% = 6.75% crit.

Anyway, just wanted to point out that you can't just read the crit rate from Rawr, because it does add other procs into that crit rate.
Nope, Rawr doesn't take elemental devastation into account on the stats panel. Just raid buffs and debuffs and Thundering Strikes and trinket procs (which I was surprised to see actually).

Seems to just be Elemental Devastation that is missed though.

Offline
Old 01/12/10, 12:01 PM   #17
Levva
In Awe of Shocks
 
Levva's Avatar
 
Draenei Shaman
 
Khadgar (EU)
Originally Posted by Rouncer View Post
Nope, Rawr doesn't take elemental devastation into account on the stats panel. Just raid buffs and debuffs and Thundering Strikes and trinket procs (which I was surprised to see actually).

Seems to just be Elemental Devastation that is missed though.
Its not "missed" really its just trying to show you similar to what would be on the paper doll if procs were included. See a couple of posts back for new version.

Edit: Rouncer can you try out the tweaked version posted above please. Your own character sheet is interesting especially the hit and crit graphs as it shows some clear "change points" where the value of hit & crit clearly hit a capping level. In fact hit is showing two such changes for you in two different directions, very interesting.

Last edited by Levva : 01/12/10 at 12:16 PM.

Author of ShockAndAwe Enhancement Shaman max dps addon
Please use the EnhSim by Ziff & others to simulate what gear, priorities etc are the best dps. You can use ShockAndAwe to export your paperdoll stats to EnhSim.

Offline
Old 01/12/10, 1:32 PM   #18
Rouncer
Deeper Shade of Blue
 
Rouncer's Avatar
 
Orc Shaman
 
Mal'Ganis
Interesting, it shows me as being over the crit cap yet when I run myself through EnhSim that is not the case. It's also not the case when I look at a combat parse. Latest Saurfang had me at 6.6% hits which shouldn't be possible if I was capped.

Even if the cap was only occurring when I had Elemental Devastation active, it still doesn't fit since I had 83.9% uptime.

I'm thinking that the discrepancy is in how we are thinking about it. Like Valdred said, it is a conversion, not a cap or a reduction. So the cap is still the same point it always was, just now even when it looks like we should be capped there will still be 4.8% of the attacks showing up as hits.

So the cap is; 100% - 24% (Glancing) - miss rate - dodge rate - parry rate = Crit Cap. Just that when you are at that cap you will still see 4.8% of your attacks show up as hits anyway.


By the way, thanks Jorev for my current headache. I'm sending you a bill for the ibuprofen.

Offline
Old 01/12/10, 1:41 PM   #19
Nevets_69
Piston Honda
 
Nevets_69's Avatar
 
Orc Shaman
 
<TG>
Arthas
I guess it depends on what you're worried about for crit cap.

I guess my personal concern is not wasting stat points on crit that could be better spend towards something else. So the crit depression still matters, since it's converting crit into hits. The cap (albeit a soft cap) still has to consider the crit depression, because you're not getting any value out of crit beyond that point (this of course is only in reference to white hits, crit still has value for other damage sources).

Elemental Shaman: You're OOM.
Enhancement Shaman: So are you.

Offline
Old 01/12/10, 2:06 PM   #20
Rouncer
Deeper Shade of Blue
 
Rouncer's Avatar
 
Orc Shaman
 
Mal'Ganis
Originally Posted by Nevets_69 View Post
I guess it depends on what you're worried about for crit cap.

I guess my personal concern is not wasting stat points on crit that could be better spend towards something else. So the crit depression still matters, since it's converting crit into hits. The cap (albeit a soft cap) still has to consider the crit depression, because you're not getting any value out of crit beyond that point (this of course is only in reference to white hits, crit still has value for other damage sources).
All it means is that as you get to the true crit cap (76% - miss %) you will want to start gemming/gearing with enough hit that you can stay under that cap, including Elemental Devastation. You also will need to keep it in mind when evaluating proc items as they may have a significant portion of their value sucked away from them by that cap.

You will get hits at the true cap but each point of crit, up to that point, will still have roughly as much value as all the ones before it.

Offline
Old 01/12/10, 2:45 PM   #21
Nevets_69
Piston Honda
 
Nevets_69's Avatar
 
Orc Shaman
 
<TG>
Arthas
I guess my issue with ignoring the crit depression is that you're pushing hits off of the hit table; whereas it seems to be more worthwhile to push misses off the hit table (with more hit rating) or to just get more swings (with haste) or else just hit harder (with AP).

Perhaps I'm misunderstanding the hit table for white attacks, but according to Synkronos' post here it looks like this:

Hit Table  
Miss  
Dodge(zero through Expertise) 
Parry(zero through positioning) 
Glancing Blow(24% always) 
Block(zero through positioning) 
Critical hit(reduced by 4.8% by crit depression) 
Ordinary hit  
Guaranteed 4.8% hit(from crit depression) 

If I've made a mistake somewhere along the way, please enlighten me.

Elemental Shaman: You're OOM.
Enhancement Shaman: So are you.

Offline
Old 01/12/10, 3:16 PM   #22
Vlyxnol
Von Kaiser
 
Troll Shaman
 
Burning Blade
Originally Posted by Nevets_69 View Post
I guess my issue with ignoring the crit depression is that you're pushing hits off of the hit table; whereas it seems to be more worthwhile to push misses off the hit table (with more hit rating) or to just get more swings (with haste) or else just hit harder (with AP).

Perhaps I'm misunderstanding the hit table for white attacks, but according to Synkronos' post here it looks like this:

Hit Table  
Miss  
Dodge(zero through Expertise) 
Parry(zero through positioning) 
Glancing Blow(24% always) 
Block(zero through positioning) 
Critical hit(reduced by 4.8% by crit depression) 
Ordinary hit  
Guaranteed 4.8% hit(from crit depression) 

If I've made a mistake somewhere along the way, please enlighten me.
This is exactly how I understand it as well. Landsoul from Vodka does a great job in summing it up in this post.

World of Warcraft - English (NA) Forums -> Testing Reveals New Melee Hit Table Behavior

Quote = Adkar (Deathknight) "Boy this would be tough for other classes"

Quote = Rouncer (Enh Shaman) " However there is a big difference between that and sticking shocks into a macro with SS and LL and spinning a mousewheel."

^ ^ ^ ^ ^
Hey! I do that!

Offline
Old 01/12/10, 3:40 PM   #23
Cobs
Von Kaiser
 
Orc Shaman
 
Malorne
Originally Posted by Rouncer View Post

So the cap is; 100% - 24% (Glancing) - miss rate - dodge rate - parry rate = Crit Cap. Just that when you are at that cap you will still see 4.8% of your attacks show up as hits anyway.
Ok I will use some round numbers here. Lets assume a Horde shaman with 368 hit for 13% hit and expertise capped.

That is 100% - 24% Glancing - 14% misses = 62% crit cap.

Now, let's say through static buffs (assume either no ED or 100% uptime ED to get to there) and gear you have exactly 62% crit. You would see 24% glancing blows, 14% misses, 57.2% crits and 4.8% hits.

Now let's say you have exactly 57.2% crit rating. Will you see either

A) 24% glancing, 14% misses, 57.2% crits, 4.8% hits

or

B) 24% glancing, 14% misses, 52.4% crits, 9.6% hits.

A conversion theory supports option B), while a "guaranteed 4.8% hit" theory supports A). I'm looking towards a B) theory and re reading my post it seems sort of redundant now. But seeing as we always observe a lower crit chance than what our paper dolls state (factoring in HoTC ToW) then the B) case must be true and 76% - miss/dodge/parry is the crit cap and not to worry about the depression.

[e] wow a lot of intervening posts. I'll leave this here incase another viewpoint helps.

Offline
Old 01/12/10, 4:01 PM   #24
Rouncer
Deeper Shade of Blue
 
Rouncer's Avatar
 
Orc Shaman
 
Mal'Ganis
Originally Posted by Nevets_69 View Post
I guess my issue with ignoring the crit depression is that you're pushing hits off of the hit table; whereas it seems to be more worthwhile to push misses off the hit table (with more hit rating) or to just get more swings (with haste) or else just hit harder (with AP).

Perhaps I'm misunderstanding the hit table for white attacks, but according to Synkronos' post here it looks like this:

Hit Table  
Miss  
Dodge(zero through Expertise) 
Parry(zero through positioning) 
Glancing Blow(24% always) 
Block(zero through positioning) 
Critical hit(reduced by 4.8% by crit depression) 
Ordinary hit  
Guaranteed 4.8% hit(from crit depression) 

If I've made a mistake somewhere along the way, please enlighten me.
I'm thinking a better way to visualize the table would be

Hit Table  
Miss(reduced by hit rating)  
Dodge(zero through Expertise) 
Parry(zero through positioning) 
Glancing Blow(24% always) 
Block(zero through positioning) 
Guaranteed 4.8% hit(due to level difference) 
Regular Hit(can be converted into crit) 

As crit really doesn't have a place in the table, it can only affect regular hit and convert it into crits.

Last edited by Rouncer : 01/12/10 at 4:36 PM.

Offline
Old 01/12/10, 5:25 PM   #25
Nevets_69
Piston Honda
 
Nevets_69's Avatar
 
Orc Shaman
 
<TG>
Arthas
Originally Posted by Rouncer View Post
I'm thinking a better way to visualize the table would be

Hit Table

As crit really doesn't have a place in the table, it can only affect regular hit and convert it into crits.
Alright, after reading your post at least a dozen times. Working out the combat table in excel, and reading quite a few posts from other class forums, here is what I've got:

Hit Table 
Miss(reduced by hit rating)
Dodge(zero through Expertise)
Parry(zero through positioning)
Glancing Blow(24% always)
Block(zero through positioning
Crit(4.8% less than what your paperdoll says)
Regular Hit(everything that is left)

The catch is this: "Regular Hit" will never go below 4.8%, this is the effect of the crit depression, which converts that 4.8% crit into hit. Even if you had 100% crit rate on your paperdoll, you would still see 4.8% of your attacks land as "Regular Hits".

So, to calculate the crit cap for your own character you just need to know your miss rate.

It works out to:
Crit cap = 100 - (miss rate) - (glancing blows)

Updating the macros that I posted at the beginning of the threat yields:

Without 3% crit boss debuff:
/script DEFAULT_CHAT_FRAME:AddMessage("Room below crit cap: "..100-(27-(GetCombatRatingBonus(6)+6))-(24)-GetCritChance())
With 3% crit boss debuff:
/script DEFAULT_CHAT_FRAME:AddMessage("Room below crit cap: "..100-(27-(GetCombatRatingBonus(6)+6))-(24)-(GetCritChance()+3))

Elemental Shaman: You're OOM.
Enhancement Shaman: So are you.

Offline
Old 01/12/10, 9:09 PM   #26
Rouncer
Deeper Shade of Blue
 
Rouncer's Avatar
 
Orc Shaman
 
Mal'Ganis
Yours means the same thing as mine, just yours requires an * to explain that 4.8% hit can't be removed and mine doesn't. For some reason I think mine matches the way Blizzard coded it better then yours but it's a moot point.

The big thing is that there is no reason to think about the relationship between the crit cap and the crit depression. You get use out of every drop up till your cap, which is dependent on your miss rate.

Basically everything that came out of all that testing is that there is no reason to every have any crit above the cap. Used to be that people thought if they had crit over that point it would eat into the crit depression and eventually allow them to remove hits from the table. That is not the case. Which is why I like my version of the table better since crits can't push anything off the table at all. All they are is converted regular hits. If you have no more regular hits to convert then you can't have any more crits.

One table, no * necessary. Basically the same as my last table but hopefully a bit more understandable.

Hit Table  
Miss(reduced by hit rating)  
Dodge(zero through Expertise) 
Parry(zero through positioning) 
Glancing Blow(24% always - due to level difference) 
Block(zero through positioning) 
Crit Depression(4.8% always - due to level difference) 
Regular Hit(can be critical strikes) 

As for your conclusions they seem to be on the money and the macros look great. I'm sure Levva will have Rawr showing the proper crit cap in the next version and EnhSim already appears to be handling it correctly. All the shaman reading this need to know is that simple equation, Crit cap = 100 - (miss rate) - (glancing blows), and that they should gem/gear for enough additional hit so their personal crit cap is always equal or better then their crit rate including all raid buffs, debuffs and the 9% from Elemental Devastation.

Offline
Old 01/13/10, 12:39 AM   #27
Schwolop
Glass Joe
 
Tauren Shaman
 
Blackrock
I'm not sure exactly what analysis you wanted Levva, but this graph is for my character sheet, swapping out all bright cardinals and stark ametrines for rigid king's ambers in order to reach this amount of hit. I just got the chest and swapped to this helm today, and lost a lot of hit rating and reached the crit soft cap as a result - this discussion is quite timely.

The graph shows that if I drop 70 hit rating I'd be below the spell cap with appropriately steep curve. If I gain another 25ish rating I'd mitigate the crit depression (which Rawr tells me is currently 0.76% over the soft cap) and then the slope is reduced again. Only after another 60ish hit rating do 2AP and haste become the top stats again.



I can edit with the Rawr XML and/or EnhSim config file if you need it.

Offline
Old 01/13/10, 11:07 AM   #28
Levva
In Awe of Shocks
 
Levva's Avatar
 
Draenei Shaman
 
Khadgar (EU)
Ok to make sure I code it right in Rawr lets see from your gear Rouncer...

Hit Table Value
Miss7.95(reduced by hit rating)
Dodge0.00(zero through Expertise)
Parry0.00(zero through positioning)
Glancing Blow24.00(24% always - due to level difference)
Block0.00(zero through positioning)
Crit Depression4.80(4.8% always - due to level difference)
Regular Hit3.90(can be critical strikes)
Crits59.35(usable crit from gear)

However should we include :

Hit Table Value
ED Uptime Av8.04(average crit granted by uptime of ED)

This would give a new table of :
Hit Table Value
Miss7.95(reduced by hit rating)
Dodge0.00(zero through Expertise)
Parry0.00(zero through positioning)
Glancing Blow24.00(24% always - due to level difference)
Block0.00(zero through positioning)
Crit Depression4.80(4.8% always - due to level difference)
Regular Hit0.00(can be critical strikes)
ED Uptime Av8.04(average crit granted by uptime of ED)
Crits55.21(usable crit from gear)
Pushed off table4.14(unused crit)


I've fixed the issue in the earlier interim Rawr.Enhance release it was double dipping on the 4.8% crit depression. I've also modified the White hit table to show the effects of over crit cap.
Attached Files
File Type: zip Rawr.Enhance.zip (1.88 MB, 144 views)

Author of ShockAndAwe Enhancement Shaman max dps addon
Please use the EnhSim by Ziff & others to simulate what gear, priorities etc are the best dps. You can use ShockAndAwe to export your paperdoll stats to EnhSim.

Offline
Old 01/13/10, 12:16 PM   #29
Darksong
Glass Joe
 
Orc Shaman
 
Kilrogg
Would it be possible to have rawr show the crit with buffs but without procs, "average" crit with procs (including average excess crit figured from average uptime of elemental devastation, and any trinket or other procs) and the "max" crit (including "max" excess crit, from everything that can provide crit proccing at the same time)?
This is just something I'd be interested in seeing, although it might not be completely meaningful for determining gear/spec choices.

Offline
Old 01/13/10, 12:39 PM   #30
Rouncer
Deeper Shade of Blue
 
Rouncer's Avatar
 
Orc Shaman
 
Mal'Ganis
Current version of Rawr (after applying the previous fix) already includes Elemental Devastation.

Rawr Paper Doll - 39.29%
SoE - 41.42%
LotP - 46.42%
Heart of the Crusader - 49.42%
Kings - 51.31%
Ele D - 58.45%

Only thing that is strange is that my Paper Doll on the Armory says 43.48% melee crit, or a difference of 4.19%. Adding that to the Rawr Total puts me at 62.64%

Giving us a table of


Hit Table Value
Miss7.95%(reduced by hit rating)
Dodge0.00(zero through Expertise)
Parry0.00(zero through positioning)
Glancing Blow24.00%(24% always - due to level difference)
Block0.00(zero through positioning)
Critical Strikes62.64%(4.8% will show as hits)
Regular Hit5.41% 

Regular hit also equals the amount of crit I can add before I reach the cap at that level of miss.


Originally Posted by Darksong View Post
Would it be possible to have rawr show the crit with buffs but without procs, "average" crit with procs (including average excess crit figured from average uptime of elemental devastation, and any trinket or other procs) and the "max" crit (including "max" excess crit, from everything that can provide crit proccing at the same time)?
This is just something I'd be interested in seeing, although it might not be completely meaningful for determining gear/spec choices.
I think Levva's solution is potentially more useful. Have it show us both the hard cap (which should include Elemental Devastation) and a soft cap (trinket procs).


Edit - played with the latest version of Rawr (the update Levva attached) and it is still showing the crit cap as too low. Crit cap really is just 100 - 24% - dodge - miss rate.

Only thing people need to know about the crit depression is that they will still see hits even if they get to the crit cap but they will get full value from all the crit rating up to that point. That's because the crit depression is active the whole way too. So if they were white hit capped and expertise capped and had 70% crit, they would only be seeing 65.2% of their attacks as crits. If they got up to 76% crit, they would see 71.2% of their attacks crit. So that 6% crit from 70% to 76% was effective. If they went up to 77% crit, however, they would still only see 71.2% of their attacks crit meaning that 1% crit from 76% to 77% did nothing.

Last edited by Rouncer : 01/13/10 at 1:09 PM.

Offline
Closed Thread

Go Back   Elitist Jerks » Class Mechanics » Shamans

Thread Tools

Similar Threads
Thread Thread Starter Forum Replies Last Post
Critical damage multiplier Dirich Public Discussion 1 11/28/07 1:17 PM
Damage Increase Per Critical Strike bloodurst Class Mechanics 7 06/29/07 11:01 AM
Blocked critical attacks possible? polocabbit Public Discussion 29 09/06/06 11:50 AM
Critical Threat and Off-hand Weapon Speed Krag Public Discussion 9 03/09/06 7:35 AM