apologies, please delete this

Every melee class in simcraft also starts attacking at 0.00

You can always imagine that 0.00 is the moment the tank gives the 'dps-call' and that everyone is in perfect position when that call comes.

Im not sure if its an intended game mechanism but when nightfall proccs the Doomguard's shadowbolts are instant. So maybe doomguard would fit better for the affliction profile in case of drain life filler?
Edit: Not sure if it works with the corruption glyph, but in case it does maybe the glyph would be pretty nice for demonology. I doubt it will pay off for destruction atleast

Does Simcraft make any additional latency assumptions on spells that require a targeting reticule to use?

I ask because I notice that because I can't queue the spell for Infernal to fire off, I have to wait for my previous cast to finish, then activate the targeting for the Infernal, then target and click my mouse. I assume all of this takes up to an extra .5 seconds to accomplish beyond the actual cast time of the spell. So I want to know if this is somehow modeled and already taken into account when comparing infernal and doomguard on a single target fight. If not, I would probably switch back to doomguard for those fights, as i do find the Infernal's spell mechanics a bit of a pain to use at times and it would likely mean the doomguards "real world" single target dps was actually superior.

I just noticed something in the destruction set
If you have the Improved Soulfire buff already on from a hard cast of soulfire you may end up wasting a soulburn. I would think you should add the check to see if the buff is up and how long the cooldown is before activating soulburns.

That's not entirely true: while simcraft correctly "sims" DC:V proc - if we try to run a profile with only drain soul in the action list trinket's uptime is, as it should be, 0% - still, Darkmoon Card: Volcano gives a ~24% uptime, compared to the 25% from destro profile.
Running the bis profile @op with Darkmoon Card: Volcano instead of Gale of Shadows we've got a 169 dps increase:



This value goes even higher with non-bis profiles, like my character, which passed from 23869 dps:



To 24149 dps:



With those numbers, even with a lower procrate <25%, it appears that Darkmoon Card: Volcano is still BiS.

Is there any way to just simulate a fight purely under 25% of the bosses health? I would like to know whether it is worth saving a soul shard and summoning my felguard during the decimation phase as the Demon Soul: Succubus is next to useless during this time. I ask mostly because we have been struggling to push enough dps on the final phase of the Twilight Ascendant, and with bloodlust next time I would think demon soul: felguard would be stronger here, and on any other fight.

Also, is there a way to add a condition to only cast Demon Soul when Metamorphosis is up or vice versa? I'm currently unsure whether I should be saving demon soul for meta as the two don't quite line up due to Impending Doom.

Small question about SimCraft, hope I'm in the right place for it (if not, could you please direct me to it?)

I fiddle with SimCraft myself from time to time and am used to using the GUI, I used to use the WoWhead import but that doesn't seem to be supported anymore so it looks like I have to alter the sim a bit for "what if" situations, right now I'm tring to find out what trinket give me the best DPS increase and I was wondering where to find the code lines for trinkets, do you guys have sufficient knowledge to type these out yourself or do you datamine it somewhere? For example:

trinket2=stump_of_time,ilevel=359,quality=epic,stats=321hit,equip=onspellcast_1926sp_ 10%_15dur_75cd

This is pretty straightforward, but I would like to know where I can find the commands for trinkets, (Sorrowsong for example doesn't seem to be implemented correctly to me) I'd like to know for instance how to code "on use" trinkets, anyone know where I can find this?

Thanks in advance.

On use trinkets:

in action list:
actions+=/use_item,name=figurine__jeweled_serpent

in gear list:
trinket2=figurine__jeweled_serpent,ilevel=346,quality=rare,stats=285int,use=1425sp_20dur_120cd

From there on it's straight forward to adapt, but importing from armory is working fine, did that fail for you too?

Wowhead will be supported again once they support reforging.

All of the special use cases, such as the trinket you listed, are found in sc_unique_gear.cpp. None of these are datamined and are hardcoded once we have accurate values from testing. Sorrowsong itself is to complicated for a simple string and has special code for it in the sim, you can find it in unique_gear.cpp as well.

On my tests it dropped to ~21% for affliction. Did you vary the time length? With a static time you could be lucky that a lot of the ICD runs during <25%.