Using the T11 Destro BiS setup, the DPET of Incinerate is 12275. The base DPET of Fel Flame is 6741. These are both with a 24% crit percentage. A 4pc proc would increase Fel Flames base DPET by 61%, to 10872. The additional 6 seconds of Immolate are more than enough to make up the gap between an Incinerate and 100% crit Fel Flame. So yes, it will be worth casting Fel Flame on procs as long as it extends a currently ticking Immolate. I am not sure how to model this in the action priority list though.
The action list part is easy:
I don't know what the name of the proc is ... and also don't know if that proc has been modelled in yet - which isn't as easy.
Concerning trinkets: I want to have Heart of Ignacious and Demon Soul used at the same time (since they line up on 2 minutes) but I honestly don't know how to change the action priority to do this. My hypothesis before testing is that affliction and demonology will see a sizeable gain from this due to the haste buff duration being the same as the demon soul effect for the succubus.
Just tested doomguard vs infernal in game, doomguard did about 1450 dps and infernal did about 1350. obviously with a 10 minute cooldown on each its quite difficult to run a large number of in game tests but I feel this should be tested further(possibly with help from other warlocks)
On the subject of trinkets, Gale of Shadows heroic is not the only item that doesn't itemise 285/285
Tendrils of Burrowing Dark heroic has a procc that averages to 340 spell power, but has 285 mastery rather than haste - Mastery being shown as worse than haste in the stat weightings for all speccs except T11 BiS affdrain.
Witching Hourglass heroic, on the other hand, has 285 static intellect, but averages to a 340 haste procc. The stat weightings for 340SP/285Haste are lower than for 285Int/340 haste, so my assumption is that the procc's affect on thresholds (how near to them it is reaching) is what causes it to lose value.
Similarly, in raids, not all items are itemised 321/321 (363/363 for heroics) - While the Bell of Enraging Resonance/Theralion's Mirror proccs are itemised this way, the spellpower from the Soul Casket use effect, Stump of Time procc and Heart of Ignacious rampup average closer to 385 (436 for Heart of Ignacious heroic rampup spellpower). The intellect procc from the Darkmoon Card: Volcano averaged close to 400, with the ICD of 45 seconds that it apparently has.
While the Heart of Ignacious has its haste in a "use" effect, which may reduce the haste's value depending on your position with thresholds, "overbudgetted" spellpower does not explain why the Gale of Shadows would perform better than Soul Casket/Stump of Time/Darkmoon Card: Volcano. (Volcano particularly I would have thought to be higher; is it being modelled with a 45sec ICD, or a 60sec ICD?)
In some cases it seems to be a matter of how the trinkets work with respect to the specific chunks of stat and the levels of stats it leaves you at, with haste particularly, while in others, my own assumption would be that the benefits either just aren't enough to compete with the SP/Haste stat weights, or perhaps some of the trinkets ICDs are not correct in the simcraft
I imported a character profile from Battle.net with the DMC: Volcano and it showed as having a 75 ICD.
Looks like this may have been updated in SVN since last time we put out a release. Solution: Look for a new release sometime in the next several days, or compile your own. (Or, more specifically for this issue, just modify the imported trinket string before simulating.)
Despite the obvious superiority in AoE fights, even in single target fights, the infernal awakening dmg would easily outweight the small dps gain the doomguard would provide over his full duration.
edit: still no simulationcraft implementation of the succubus's whiplash aoe attack which does quite strong dmg (~3k dmg per mob) and has a knockback effect like thunderstorm but weaker
I wasn't suggesting that using one over the other was better, just that the current sims show with bis preraid gear that infernal seems to do like 3.3k dps single target which seems quite high unless raid buffs can nearly do 250% for guardians dps
Where do you get your numbers from? I fiddled around with a spreadsheet and come to different conclusions: Caster Trinket Comparison
I hope the calculations are explained well enough.
Although different specs might result in slightly different uptimes for the procs, the proc's benefit should not vary much more than 10%.
Using AffDrain PreRaid numbers , e.g., we see that the Darkmoon Card and Theralions Mirror are Best-In-Slot and that someone should update the BiS Lists with these two trinkets.
I used the numbers from the "old" profile with the felhunter, because I doubt that the succubus is going to stay that way.
Taking a look at the scalefactors of other specs and classes that similarly favor INT way more than any rating I think the dkp prices for theralions mirror will be high and one should invest in volcanic decks :-)
Edit: Thanks to Ankhyus for pointing out a copy/paste error in the spreadsheet. It is now updated. The differences are not that big anymore, but still exisiting.
For the preraid gear, surely the blue PvP set is BiS?
It's set bonuses offer 250 intel and 5% cast time reduction on SB/Incin. If you had 4 parts excluding the head because I think there is one item that is slightly better that is.
Is there anyway anyone can figure out the value of the set bonuses and factor that into BiS list?
If you want to equip the PvP Set, you will leave out the hands and equip the epic faction gloves. Then you will have 797 ratings points wasted in resilience but gain 250 int, which is definitely an overall loss (250*3 - 800*1.5=-450 dps). The Bonus however should be worth
Affliction: 3954 DPS through Shadowbolts-> 208 dps
Demonology: 3762 DPS through SB and Inc -> 198 dps
Destruction: 4022 DPS through Incinerate ->212 dps
according to the current BiS preRaid profiles.
The PvP Set has a little bit more stamina and int (due to the higher ilvl) but also crappy socketing bonuses. Overall the PvP Set (with 4pieces) is quite useful in PvE, but certainly not BiS.
In the Affliction Drain profiles with the change to use the Succubus, I notice that the spare point in the spec is still being used in Dark Arts. Obviously, this is an artifact from when the Felhunter was the predominant Affliction pet and is not providing us any benefit by remaining there.
It seems like this point may end up being a utility point, in the long run, though. I don't see any significant single target DPS gains by moving back to Bane or putting it in any of the Affliction talents. To me, it seems like the best use would be in either Curse of Exhaustion, if some form of kiting is needed for a fight, or in Soulburn: Seed of Corruption, for add heavy boss fights. The benefits of this change are obviously not going to be shown in SimCraft parses, but it may be beneficial to make that adjustment in the specs you use anyways, to avoid any possible confusion.