That was not my point.
Rain of Fire not triggering it is a DPS loss for my spec, so my question is: does anyone know if Illustration not working with Rain of Fire is a bug or intentional (and if the latter, were there any reasons why given)?

Can you explain the calculations in detail so we can use it to calculate the dps of other trinket procs?

Thanks

I haven't had good luck with DC, IoDS or even Embrace, so I've been using [Battlemaster's Bravery] along with the Sundial as Affliction. The math is simple, a static 111 spell power, but that seems pretty solid at the very least. It's obviously worse than IoDS, DC and Embrace, but where would it rack up against the Egg, Sundial, Extract, and Mark of the War Prisoner? I'll likely be getting either IoDS or DC first, so I'm wondering whether the Sundial or Battlemaster's should go first.

I'd say its so you can't get 10 stacks up by casting r1 RoF before you go into combat.

It would be useless to stack it up that way, since lower spellranks actually cost more mana than the highest spellrank does these days.

Since no other channeled spells stack it up either, I would assume this is intended. Apart from Health Funnel which actually only proc it on the initial hit.

RoF triggering it per-hit would be crazy OP. However adding a stack per cast would be reasonable as otherwise casting an AoE or two would pretty much wipe out your stacks, thoroughly nerfing your DPS.

(dmg * (1-crit_rate) + (dmg *1.5) * crit_rate) / seconds_between_procs = dps
(2000 * 0.65 + 3000 * 0.35) / 50 = 47

The simpler version is

(dmg *(1 + .5 * crit_rate))/time = dps

That is exactly what I think and exactly what I'm experiencing. It is hardly unheard of that a piece of equipment does not support a single spec or tactic perfectly, but this case really smells of bug here.
Especially when I can trigger it off-combat with Health Funnel and Lifetap.

(I thought I had posted already but can't see my post, if this ends up being a double sorry everyone).

Thats not what Yeda proposed. Read again: "Initial hit" means adding one stack for the first damage component of the channeled spell, much as you yourself suggest right after:

Everyone is pretty much in agreement how this spell should work.

[Darkmoon Card: Crusade] used to stack from each hit of Seed of Corruption. It was quite a nice trinket for raiding Mount Hyjal since it would be fully stacked after the first explosion. I haven't noticed recently if it still behaves in the same way, and I think I've now sold it to a vendor after upgrading it to IDS. I don't recall if it stacked off RoF or not, since throughout BC, that spell was only for playing around in Ironforge or in the Alterac Valley starting cave. It never stacked out of combat through Life Tap or Health Funnel, though.

I've seen conflicting reports of the ICD being 15 or 30 seconds now. Can anyone confirm this?

It's still 45 sec. on PTR atm.

I find it weird that RoF does not work with IDS nowaday because Darkmoon Card: Crusade does and preWotLK I'm pretty sure it didn't, not with RoF or Hellfire. So it confuses me that I can easily get a full stack of Crusade with one RoF cast but not the same with IDS. Blizzard isn't known for retrospective buffing so I'm not sure why Crusade works with RoF all of a sudden, or perhaps it always did and my memory fails me.

IDS needs to work with healing spells, so they had to implement different restrictions to prevent it from working with any spell. There were a few iterations when they started changing it and it seems they haven't come up with a better solution yet.

I recently got Embrace of the Spider and is know trying to decide wheter its better than Sundial or not. From a pure theorectical point of view the embrace should beat Sundial by quite alot. Im however specced affliction so with eradiction up and trinket proccing Im suddenly above the hastecap so the trinket proc is partly wasted. Same is of course true during heroism. Anyone input would be thankful

Just to offer supporting evidence; IDS doesn't work with Hurricane either. It seems the heart of the matter is whether it should proc on AoE spells or not. I can see reasons to support both sides.

When you consider that Health Funnel works with IDS (which is a very cheap way to pre-stack it) and if I recall correctly, the first stack of hellfire also procs IDS I would say that rain of fire not proccing it most likely a bug in the way it procs.

Haste cap is 1639, but with Eradication (655.8 Haste Rating on Proc) and Embrace of the Spider (505 Haste Rating on Proc) both up at the same time, you only need 479+ Haste Rating to be over the cap. Given that I know fresh-80 Warlocks with more Haste than that, it's a legitimate concern.

I agree with you that Embrace is the way to go, but when taking procs into account, haste cap is rather easy to reach and exceed, and would in fact impact the usefulness of Embrace.

I have noticed no one has mentioned [Majestic Dragon Figurine] at all. With Fel Armor currently granting 30% of my spirit as spellpower and the new glyph in 3.1, Glyph of Life Tap (20% of my spirit to spellpower when I tap), is this trinket truly undeserving of any mention? In the current patch it is approximately 56 spellpower and in 3.1 it will be 90 spellpower. Is this a trinket worth considering while I wait for [Illustration of the Dragon Soul]?

Firstly, it's worse than the other epic trinkets you can get (like Sundial, Embrace of the Spider, etc). Secondly, it's MUCH better for a healer than it is for you. You taking that trinket is effectively the equivalent of a healer taking Illustration.

I think thats a pretty heavy understatement, Illustration of the Dragonsoul is far better for healers than the Majestic Dragon Figurine is for DPS.