2xT9 also effects regular Felguard melee swings.

Felguard's melee swing should be at about 35% crit rate assuming I have 30% crit.
It has about 5% base crit, 10% from Demonic Tactics, 0.3*30%=9% crit from Imp Demonic Tactics. then 10% from 2T9. But all tests I've done on dummies show no more than 30% crit, sometimes as long as 20%.
I did about 5 rounds, each with exact 100 swings. I get about 40-50% hit, 25-30% crit and 25-30% glancing. It's either I'm extremely unlucky with RNG or something's wrong.

Other people (including myself) have ran tests with 5k+ melee attacks, 100 melee attacks is really not enough to base anything on.

I've been looking at recount data after full 25 man raids and I'm a little bit concerned that they might have fixed it :< Cleave critrate seemed to be 5-8% higher than regular melee attacks on average. But I don't think it's accurate enough information and will see if I can get some time to run new tests with the latest patch. Or did you do any recently? I'm hoping bad RNG.

Can you prove that?
I thought only "Styles" get affected by 2T9?!

It's been tested by several people, anyway I'll test it again and post screenshots this time around.

[edit] I'll upload screenshots when I've ran all tests.

I've done 3 text runs with 2xT9, totals:
6623 Melee swings, 1728 crits (26.1% crit)
1949 Cleaves, 562 crits (28.8% crit)

Obviously cleave crit% isn't 10% above melee, so that idea is more or less off the table. Cleave crit% is slightly higher- possibly due to it's secondary target being level 70, and thus having lower defense (as such getting critted more), however ~2000 cleaves isn't too big a sample size, it could just be 2.7% higher due to RNG.

I have a question regarding multiple Meta (0/56/15 /w Demonic Pact) specced demo locks in a raid group.
Anyone tested the mechanics, how do the buffs overwrite each other?
Since we are talking about a non-permanent buff of course i'm only interested in a situation where all demonic pacts are up: does the highest buff overwrites the lesser ones or the one gained first remains for the whole duration?
(we have found Immolation aura very helpful at Anub(25) heroic)

Whichever one procced last is the one you'll have. IE: If you have someone with 5k spellpower have his felguard crit, you'll get 500sp, if the next second someone with 1k spellpower has his felguard crit, yoru demonic pact will drop down to 100 spellpower.

It is most definitely not worth it to run with more than 1 demonic pact Warlock.

[edit] And at the guy above that, sorry but your sample size is about 20 times too small to draw any kind of conclusion from.

Yeah i know it was late and i was headed too bed just thought I'd contribute too the thread I will do a much larger example sometime today.

I've done 3 test runs with 2xT9, totals:
6623 Melee swings, 1728 crits (26.1% crit)
1949 Cleaves, 562 crits (28.8% crit)

I've done 1 big run with 0xT9, totals:
5558 Melee swings, 1056 crits (19.0% crit)
1043 Cleaves, 183 crits (17.5% crit)

There will always be some inaccuracy unless you really use absolutely absurd sample sizes, however you can tell from this sample size that cleaves are not getting a special +10% crir treatment, and you can also pretty confidently say that with 2xT9 all crit appears to go up ~10% (both cleave and melee).

Screenshots:
2xT9: Melee 1, Melee 2, Melee 3, Cleave 1, Cleave 2, Cleave 3
0xT9: Melee 1, Cleave 1

Hmhm, thanks a lot for the tests, I did not get a single chance to run them myself. I'm happy with those results

What about a 10man raid? Is it necessary to have a demo lock? We only have one lock that is myself and simcraft says it is an overall increase in raid damage, but what about when considering high movement fights etc?

We don't run with a shaman usually.

It is important to keep in mind that the 3% crit increase is covered by many other classes. MOST importantly keep in mind that TOW is not up 100% of the time. Due to fights that involve movement and the fact that everyone is not in a static location every fight the 40 yd range on TOW means the uptime is not 100%.

Can anyone suggest a way of measuring the value of the Demonic Pact buff (other than continuously mouse-over the buff icon) to provide an average value for the duration of a fight.

Due to various proc's on my gear (Dying Curse, Lightweave Embroidery, Illustration of the Dragon Soul, etc), the DP value at the start of the fight simply represents the minimum. Combination's of proc's can result in a huge spell power difference, but knowing the maximum and average value of DP would be a more helpful measure of the rDPS value of the buff.

The best way to do this would be to utilize simcraft.

Take your buffed spellpower(Minus Totem of Wrath/Flametongue unless you are using /cancelaura Demonic Pact in all your spells and one of the totems exist.).

Once you get that start adding trinkets/glyph of life tap/lightweave embrodiery. Make sure you multiply each by its corresponding effectiveness to find there average values. For example lightweave has an effectiveness of about 25% so in order to add that in, I would need to multiply its spellpower proc by 0.25. Glyph of life tap should have an effectiveness of close to 100%, and other trinkets vary, which is why I suggest simcraft to figure that out.

Once you get the total average spellpower, then you can easily determine demonic pact's average value by multiplying the uptime of demonic pact by the amount of spellpower it grants.

Has the mechanic of DP changed?

I was under the impression that because the buff was refreshed rather than being re-applied on pet crit, the average SP granted by the buff could be considerably higher than my average SP.

E.g. (using arbitrary figures) at fight start I have 3k SP, pet crits applying 300SP buff. The buff increases to 320SP with Illustration of the Dragon Soul. Due to lucky RNG, Dying Curse proc's during the 15sec proc of Lightweave giving me 4260SP, so now the DP buff is up to 426SP which (assuming the pet continues to crit) will be refreshed for the duration of the fight despite the fact that after 10sec my personal SP will return to 3200. Even assuming bad RNG (i.e. non-coinciding proc's), DP would still refresh a value of 399SP because of the Dying curse proc.

If it is a 5min fight and it takes 10sec to fully charge IotDS and the Lightweave/Dying Curse proc happens at 30sec, then the average SP granted by DP would be ~412.

Your suggestion of using proc values multiplied by up-time would result in a significantly lower DP value.

Can anyone clarify/confirm the DP mechanic?

Not sure how I missed this post, given that DP mechanics are my personal obsession :P

The buff amount *is* updated on refresh, so a temporary large buff can only be maintained for a single 45-sec duration, by pulling the demon from combat before his internal CD is down to prevent him from refreshing. Then you'd have to send him back in before the buff drops so he can proc again without down time. Almost certainly a dps loss overall.