Originally Posted by dedmonwakeen
Does the Imp only get spell crit from buff-related Intellect and not base Intellect? If so, please open an Issue to make sure I make the fix.
|
Just doing some napkinmath here based on the post I did earlier:

Originally Posted by Warlocomotif
Some quick numbers here:
Imp Base intellect: 424
With 1023 intellect (864 int from gear) my imp gains 306 intellect. +15% = 775 @ 5.56% crit
With 937 intellect (778 int from gear) my imp gains 281 intellect. +15% = 747 @ 5.39% crit
With 824 intellect (665 int from gear) my imp gains 247 intellect. +15% = 708 @ 5.16% crit
Difference in int from gear between sample 1 and 2 is 86, 25 int difference to imp.
Difference in int from gear between sample 2 and 3 is 112, 34 int difference to imp.
Difference in int from gear between sample 1 and 3 is 199, 59 in difference to imp.
Conclusion: Imp gains ~ 30% of masters intellect (but im pretty sure we already knew this)
Difference between pet intellect between sample 1 and 2 is 28 intellect, and 0.17% crit.
Difference between pet intellect between sample 2 and 3 is 39 intellect, and 0.23% crit
Difference between pet intellect between sample 1 and 3 is 67 intellect, and 0.4% crit.
Conclusion: Imp gains 1% crit per ~167 intellect, same as master.
|
775/167=4.64% This is 0.92% less than the actual crit chance (5.56%)
747/167=4.47% This is 0.92% less than the actual crit chance (5.39%)
708/167=4.24% This is 0.92% less than the actual crit chance (5.16%)
It should be noted that the 166.67 int per 1% crit is calculated by looking at differences in crit% and intellect, meaning that those numbers should be solid regardles of base crit%. What this suggest is:
[1] The imp has 0.92% chance to crit before intellect (Before base intellect aswell)
[2] The imp gains 1% crit for every 166.67 int after this point.
[3] The imp gains 30% of our total intellect, *1.15 due to Fel Vitality.
Now if I'm doing everything right, this means:
Player=Warlock_T8_00_13_58 (destruction) DPS=8346.5 (Error=+/-3.6 Range=+/-653) DPR=25.8 RS=322.9/257.1 (mana)
Origin: Profiler - Wowhead
Race: undead
Core Stats: strength=68(10) agility=75(10) stamina=1108(946) intellect=1042(885) spirit=540(369) health=18390 mana=19666
|
Our imp has 424 base intellect, he gains (1042+60+52)*1.1*0.3*1.15=438 intellect from our gear and buffs.
Which makes it: (424+438+((60+52)*1.15))*1.1=1089.88 intellect.
Notes: 60 = Arcane Brilliance, 52 = Talents Gift of the Wild, *1.1 = Greater Blessing of Kings, *1.15 = Fel Vitality
1090 intellect means ~6.53% crit, +0.92% base crit = 7.45% crit. If you add 5% from ISB and 5% from moonkin, that totals at 17.45% crit.
I *think* these numbers are correct, but would like to get them double checked before I post a ticket.
[edit] After the raid tonight ill let my imp go to home on the practice dummy for a while to check if there isn't also another base crit value hidden somewhere.