Elitist Jerks
Register
Blogs
Forums


Go Back   Elitist Jerks » Warriors

Closed Thread
 
LinkBack Thread Tools
Old 01/21/09, 1:54 PM   #226
Senjion
Glass Joe
 
Senjion's Avatar
 
Blood Elf Paladin
 
Garrosh
Just reporting in that the Ring Slot 1 socket detection is currently:

=IF(VLOOKUP(T14,Lookup!FN2:GA222,14,FALSE)=0,"",VLOOKUP(T14,Lookup!FN2:GA222,14,FALSE))
When it should be:

=IF(VLOOKUP(T14,Lookup!FN2:GA222,12,FALSE)=0,"",VLOOKUP(T14,Lookup!FN2:GA222,12,FALSE))
Other than that and the already reported runtime error in 2003 it looks and works great!

EDIT: Just noticed it was fixed in 2.301. So Great work!


Canada Offline
Old 01/21/09, 1:59 PM   #227
Ariakis_Uther
Glass Joe
 
Human Warrior
 
Kilrogg
I fixed the runtime error in 2003 and I'm looking a little further into making it faster.

To fix the error select AM29:AN29 through AM44:AN44 and click format cells, make sure the merge cells checkbox is unchecked and then select "Center Across Selection" in the Horizontal text alignment drop down box. Click OK and your SEP should calculate.

Offline
Old 01/21/09, 2:07 PM   #228
Daronsk
Von Kaiser
 
Orc Warrior
 
Mal'Ganis
Originally Posted by Ariakis_Uther View Post
I fixed the runtime error in 2003 and I'm looking a little further into making it faster.

To fix the error select AM29:AN29 through AM44:AN44 and click format cells, make sure the merge cells checkbox is unchecked and then select "Center Across Selection" in the Horizontal text alignment drop down box. Click OK and your SEP should calculate.
I can confirm that this does indeed fix the runtime error.

Great job btw Landsoul the spreadsheet looks great and it takes alot less time to input a fresh gear set.

I did notice a bug with the racial weapon expertise. Selecting racial weapon expertise 5 and activating the axe spec took my dodge percent from 1.65% to -2.10%. The off hand remains at 1.65% dodge unless I activate it as well. It also has the same behavior if activated. This wouldn't be a big issue but it throws the SEP value way off and puts expertise as having a SEP of >1.8 and ends up showing BOH over jawbone as a >400dps increase.

Last edited by Daronsk : 01/21/09 at 2:26 PM.

Offline
Old 01/21/09, 3:37 PM   #229
landsoul
Myrmidon Champion
 
landsoul's Avatar
 
Worgen Warrior
 
Alterac Mountains
delete

Last edited by landsoul : 01/21/09 at 5:24 PM.

>--Coaching Site--< Private coaching / Warrior Resource
>--Stream--< Tues, Wed, 7 Eastern.

Offline
Old 01/21/09, 5:02 PM   #230
premed
Glass Joe
 
premed's Avatar
 
Human Warrior
 
Quel'dorei
This might have already been address, but did not see anything about it.

Why are there pole arms on the list when this is a Fury spreadsheet, and TG warriors cant equip pole arms in both hands

Offline
Old 01/21/09, 5:08 PM   #231
Ariakis_Uther
Glass Joe
 
Human Warrior
 
Kilrogg
Originally Posted by premed View Post
This might have already been address, but did not see anything about it.

Why are there pole arms on the list when this is a Fury spreadsheet, and TG warriors cant equip pole arms in both hands
Landsoul said he had them in there in case he ever wanted to add arms to the spreadsheet.

Offline
Old 01/21/09, 5:09 PM   #232
Daronsk
Von Kaiser
 
Orc Warrior
 
Mal'Ganis
Its a pretty tricky bug and I'll include a few notes I have about it as you seem to have found it too at this point.

-Occurs only when the spec based Expertise breaks the cap
-Adding a pure expertise gem will solve the bug, but a hybrid expertise gem will not.

And yes, it has nothing to do with the spec activator. That was me miss reading the sheet.

Offline
Old 01/21/09, 5:50 PM   #233
Barmbul
Von Kaiser
 
Barmbul's Avatar
 
Tauren Warrior
 
Dragonmaw
I am having a problem with the sheet taking way to long to calc SEP. I am running Excel 2007. Are the setting on the cover sheet still correct for 2007?

The sheet shows 32767 interations with min change to .00000000001.

This calc is taking minutes to do.


Offline
Old 01/21/09, 6:29 PM   #234
landsoul
Myrmidon Champion
 
landsoul's Avatar
 
Worgen Warrior
 
Alterac Mountains
Try lowering the maximum calculations and min change.

I lowered the max calcs all the way down to 10 and experienced +-3 ten thousandths in some fields. You will probably be able to get away with 100 and min change of .00001 and have things still be accurate. Anything lower and you will get erroneous results.

The speed of the calculations is dependent also on your PC performance. Faster and Dual and Quad core processors usually can crunch faster.

Last edited by landsoul : 01/21/09 at 6:38 PM.

>--Coaching Site--< Private coaching / Warrior Resource
>--Stream--< Tues, Wed, 7 Eastern.

Offline
Old 01/21/09, 7:00 PM   #235
Dagronjr
Glass Joe
 
Orc Warrior
 
Detheroc
I haven't downloaded a new version of the spreadsheet for a few days, but when I was messing with it before, it was giving expertise no value even when I was below the dodge expertise cap. I know there's a way to make it take into account full value, but is there anything I can do to make it value expertise up to cap but not overvalue it?

Offline
Old 01/21/09, 8:53 PM   #236
Mightybeast
Glass Joe
 
Tauren Warrior
 
Aggramar
I think a REALLY great feature would be to have an extra column in the lookup tab (or anywhere really) that shows where the item drops/crafted. Would really add another dimension to the spreadsheet. It probably isn't that hard to do myself, but I'd have to sort through your lookup functions and change everything to add the colums.

Offline
Old 01/21/09, 9:31 PM   #237
landsoul
Myrmidon Champion
 
landsoul's Avatar
 
Worgen Warrior
 
Alterac Mountains
You could do that in 2007 for sure, but in 1997 there isn't enough column space. In order to do it in 97 you would have to flip the entire page vertically and stack up all the item types on top of eachother.

>--Coaching Site--< Private coaching / Warrior Resource
>--Stream--< Tues, Wed, 7 Eastern.

Offline
Old 01/22/09, 2:38 AM   #238
NobleHelium
Von Kaiser
 
Night Elf Warrior
 
Uther
I'm going to have to say that the gem input is still taking up an unreasonable amount of time. The STR versions of the gems (inscribed, etched, sovereign, etc.) seem to be in the game now. Why not just remove the AP and uncommon gems entirely to cut down on the amount of scrolling?

Offline
Old 01/22/09, 6:30 AM   #239
Kaoz
Von Kaiser
 
Kaoz's Avatar
 
Gnome Mage
 
Sargeras
Just would like to let you know that my gear setup reaches higher dps than the ideal default one. It's also slightly easier to attain. Only my ranged weapon isn't optimal.

Does anyone have a better setup?

Offline
Old 01/22/09, 7:12 AM   #240
Azhag
Glass Joe
 
Azhag's Avatar
 
Orc Warrior
 
Gorgonnash (EU)
great job, the new design of your spreadsheet is well arranged and handy

Offline
Old 01/22/09, 10:56 AM   #241
Grayson Carlyle
Take what ye can;
 
Grayson Carlyle's Avatar
 
Tauren Warrior
 
Turalyon
[Enchanted Tear] is missing from the gems.

Canada Offline
Old 01/22/09, 12:07 PM   #242
rejdakon
Von Kaiser
 
Human Warrior
 
Der Rat von Dalaran (EU)
Originally Posted by Daronsk View Post
I did notice a bug with the racial weapon expertise. Selecting racial weapon expertise 5 and activating the axe spec took my dodge percent from 1.65% to -2.10%. The off hand remains at 1.65% dodge unless I activate it as well. It also has the same behavior if activated. This wouldn't be a big issue but it throws the SEP value way off and puts expertise as having a SEP of >1.8 and ends up showing BOH over jawbone as a >400dps increase.
I get the same thing when choosing 3 points racial expertise. 1.15% dodge without it, -1.10% with it. When choosing 5 pints racial expertise, dodge is correctly shown as 0.00%.

Offline
Old 01/22/09, 4:11 PM   #243
landsoul
Myrmidon Champion
 
landsoul's Avatar
 
Worgen Warrior
 
Alterac Mountains
nvm

Last edited by landsoul : 01/22/09 at 4:21 PM.

>--Coaching Site--< Private coaching / Warrior Resource
>--Stream--< Tues, Wed, 7 Eastern.

Offline
Old 01/22/09, 4:25 PM   #244
Kaoz
Von Kaiser
 
Kaoz's Avatar
 
Gnome Mage
 
Sargeras
Originally Posted by landsoul View Post
nvm
What happened?

I just tried your setup and I do gain ~30dps. You have to manually turn off 2piece T7 though, which I valued a bit higher.

I also think that losing so much armor is depressing, it removes my ability to tank trash in 5mans and also makes rogues harder to deal with in battlegrounds. Based on what I've read though, Blizzard has said they won't itemize everything perfectly because they want people to have items to look forward to in Ulduar. We're just lucky we can wear anything and pick and choose the best items designed for each armor type.

edit: I found the ultimate setup!

It consists of my current gear with Blue aspect helm and the blue slot having a 27 hit gem in it. I got 6817 with that.

I forgot to change my ranged slot to Spinning Fate though.

Last edited by Kaoz : 01/22/09 at 4:43 PM.

Offline
Old 01/22/09, 4:51 PM   #245
Graul
King Hippo
 
Graul's Avatar
 
Orc Warrior
 
Fenris
Originally Posted by Kaoz View Post
What happened?
Blizzard has said they won't itemize everything perfectly because they want people to have items to look forward to in Ulduar. We're just lucky we can wear anything and pick and choose the best items designed for each armor type.
That's a depressing attitude to have. "Let's make suboptimal gear so you can be excited when we actually implement items that don't waste stat costs!". I never saw a post like that, but it wouldn't suprise me at all, especially after seeing the transition between Sunwell plate and entry level WoTLK raiding gear.

Offline
Old 01/22/09, 5:10 PM   #246
Kaoz
Von Kaiser
 
Kaoz's Avatar
 
Gnome Mage
 
Sargeras
Originally Posted by Graul View Post
That's a depressing attitude to have. "Let's make suboptimal gear so you can be excited when we actually implement items that don't waste stat costs!". I never saw a post like that, but it wouldn't suprise me at all, especially after seeing the transition between Sunwell plate and entry level WoTLK raiding gear.
God bless google : World of Warcraft - English (NA) Forums -> Could we get a statement on itemization?

It is not our goal to make sure that every piece you can get is perfect for your class or spec. A lot of the game's depth comes from those tough decisions when you're not sure if a piece is really an upgrade or not, or if that wasted stat is worth the other enormous stat on the piece, or if you are better off passing a minor upgrade to someone else for which it is a huge upgrade.

Upgrades are also boring if every piece = your previous piece but with +2 on all of the stats.

If someone just can't do their job because they lack critical gear, that's a slightly different issue. There have been cases where a critical item (say a tanking shield) was too rare, or upgrades were too hard to come by (say druid or paladin tanks in Sunwell). We think there is a little bit of that going on at the moment, but not too much, and of course we like to add more drops, vendor items, craftables and enchants and gems over time (and need room to do so).

Offline
Old 01/22/09, 6:13 PM   #247
ebs2002
Von Kaiser
 
Orc Warrior
 
Sisters of Elune
I'm looking at the Hunter_DPS sheet for info on an armory import, and this is roughly how it should work:

Dim url
url = "http://" & server & "/character-sheet.xml?r=" & realm & "&n=" & character_name & "&lang=en_us"

If IsNull(ThisComponent) Or IsEmpty(ThisComponent) Then
   Set Node = GetSingleDataXLS(url, "//character")
Else
   Set Node = GetSingleDataOO(url, "//character")
End If

If Node Is Nothing Then
   MsgBox "There is no character of that name found"
Else
   'Node is now an XML node that is the root of all your character data, and can be accessed like so:
   race = Node.Attributes.getNamedItem("race").Text
   Worksheets("Set1").Range("B30").value = race

   'or more compact:
   Worksheets("Set1").Range("B30").value = Node.Attributes.getNamedItem("race").Text

   'To access items, you set the node to "//items/item" using the above method to get a list of nodes, and iterate over each one:
   Set NodeList = GetDataXLS(url, "//items/item")
   For i = 0 To NodeList.Length - 1
      Set Node = NodeList.item(i)
      slot = Node.Attributes.getNamedItem("slot").Text 'tells you what slot you're looking at
      itemName = getItemName(Node.Attributes.getNamedItem("id").Text)
      gem1 = getItemName(Node.Attributes.getNamedItem("gem0Id").Text)
      'etc for gem1Id, gem2Id

      'For enchants, there's a way to look up the tooltip to get the enchant name, and there's also a way to do talents and whatnot, but I think this is enough for now
The helper functions used:
Function GetSingleDataXLS(url, searchterm)
    Set objXMLHTTP = CreateObject("MSXML2.ServerXMLHTTP.3.0")
    objXMLHTTP.Open "GET", url, False
    objXMLHTTP.SetRequestHeader "User-Agent", "Mozilla/5.0 (Windows; U; Windows NT 5.0; en-GB; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4"
    objXMLHTTP.SetRequestHeader "Content-Type", "text/xml"
    objXMLHTTP.SetRequestHeader "Accept-Language", "en"
    objXMLHTTP.Send ""
    Set xmlPG = objXMLHTTP.responseXML  'Get the XML in xmlPg
    
    If xmlPG Is Nothing Or xmlPG.DocumentElement Is Nothing Then
        Set GetSingleDataXLS = Nothing
    Else
        Set GetSingleDataXLS = xmlPG.DocumentElement.selectSingleNode(searchterm)
    End If
    Set objXMLHTTP = Nothing
    Set xmlPG = Nothing
End Function

Function GetSingleDataOO(url, searchterm)
    Dim oMSXML
    Set oObjFactory = createUnoService("com.sun.star.bridge.OleObjectFactory")
    Set oMSXML = oObjFactory.createInstance("MSXML2.DOMDocument")
    oMSXML.async = False
    oMSXML.validateOnParse = False
    oMSXML.resolveExternals = False
    oMSXML.Load (url)
    Set oNodes = oMSXML.selectSingleNode(searchterm)
    If IsNull(oMSXML) Or IsNull(oNodes) Then
        Set GetSingleDataOO = Nothing
    Else
        Set GetSingleDataOO = oNodes
    End If
    Set oMSXML = Nothing
    Set oObjFactory = Nothing
End Function

Function getItemName(id As String)
    Dim sUrl
    Dim sName
    Dim sServer
    
    sServer = Worksheets("Realms").Range("UrlStart").value
    sName = ""
    sUrl = "http://" & sServer & "/item-info.xml?i=" & id & "&lang=en_us"
    
    If IsNull(ThisComponent) Or IsEmpty(ThisComponent) Then
        Set Node = GetSingleDataXLS(sUrl, "//itemInfo/item")
    Else
        Set Node = GetSingleDataOO(sUrl, "//itemInfo/item")
    End If
    
    sName = Node.Attributes.getNamedItem("name").Text
        
    getItemName = sName
    
End Function
I definitely don't have the time to port the code myself for you at this time, but this should be enough to get you started. I know a fair bit of VB and could help you if you'd like. Also, my company just announced 5k job cuts over the next year, so in the event that I'm unemployed I'll have more than enough time to help you with this if you need :p

Offline
Old 01/23/09, 5:37 AM   #248
Mace
Glass Joe
 
Night Elf Warrior
 
Dunemaul (EU)
Landsoul, the items you have selected in the spreadsheet is to show the highest DPS possible?
If so, equiping [Surge Needle Ring] instead of [Ruthlessness] and change 1x 16STR gem to a 16Exp gem gives a slight DPS increase (around 15 with the buffs selected)

Offline
Old 01/23/09, 8:38 AM   #249
Whistles
Piston Honda
 
Gnome Rogue
 
Staghelm
Just wanted to pop in to say amazing job on the newest version of the spreadsheet! The gem changes simplify things a lot.

Offline
Old 01/23/09, 9:47 AM   #250
bimmy
Glass Joe
 
Dwarf Paladin
 
Korgath
Originally Posted by Mace View Post
Landsoul, the items you have selected in the spreadsheet is to show the highest DPS possible?
If so, equiping [Surge Needle Ring] instead of [Ruthlessness] and change 1x 16STR gem to a 16Exp gem gives a slight DPS increase (around 15 with the buffs selected)
I get higher DPS from the spreadsheet equipping instead: [Blue Aspect Helm], [Chestguard of the Recluse], [Sinner's Bindings], [Surge Needle Ring] (over [Ruthlessness]) and [Grim Toll] (over [Mirror of Truth]).

Offline
Closed Thread

Go Back   Elitist Jerks » Warriors

Thread Tools

Similar Threads
Thread Thread Starter Forum Replies Last Post
Mongoose calculation or simulation? sag_ich_nicht Public Discussion 1 08/05/08 9:59 AM
[Rogue] Backstab damage calculation Karmon Class Mechanics 5 11/04/07 5:22 PM
Range Calculation Nite_Moogle Theorycrafting Think Tank 0 09/21/07 12:02 PM
Ilvl calculation Drauk Public Discussion 9 03/24/06 4:30 PM