Hi there!
Now that all the content is on farm for a sufficient amount of time, I think it's time to look back at how Warrior tanking developed in Wrath and what is left to improve (or if there is anything left to improve in your opinion). I realized that we didn't have a proper Prot Warrior tank thread yet to discuss these things so let's use this one (people just throw in tidbits in the other threads, but I think we should channel this stuff into one thread).
First off, let me say that I absolutely love the tanking style in Wrath (Warbringer, new Shield Block, Shockwave etc) so while this post might seem to put it in a negative spot light - it's not. I am merely focusing on the parts that could end up giving us trouble later down the road in comparison to other tanks or flaws in the class itself. Also, keep in mind that whining and wish listing is frowned upon on these forums so try to keep things factual so we can properly discuss things.
Tanking aspects:
1) The dependence of getting hit and what happens if you are not:
a) The rage dilemma
This right here is my biggest concern. With better gear, we are still seeing the same problems we had to face in TBC and Vanilla: Rage starvation. A Prot Warriors rage generation is still mostly dependant on getting hit and while the idea of upping our white melee damage was a nice one, it doesn't compensate nearly enough. If you are caught in an avoidance streak or blocking big parts of a mob's swing, you are in a big trouble unless you have Blessing of Sanctuary (more about that later). Moreover, we are still reliant on Heroic Strikes to build threat (if not now, later when DPS is catching up on threat) and as you all know, Heroic Strikes eat our melee swing. So effectively, HSing actually got
more expensive for us because our white melee swing generates a bit more rage than in TBC. I am sure that this is why we are all glyphed for Revenge but even then, it's not enough and I absolutely refuse to wear DPS gear just so my incoming damage is bigger. We just shouldn't have to, because DPS gear just isn't part of our tanking gear progession just like how healers don't have to swap in DPS gear to do their jobs. Don't get me wrong, I understand the concept of having multiple gear sets but a DPS set for tanking? No thanks.
So what's the solution? I bet you are all saying
Blessing of Sanctuary - Spell - World of Warcraft and you are half right. BoSanc is great because it scales
positively with our gear (unlike rage generation from getting hit, which scales
negatively with our gear) and this is how it should be. You get better gear and you should be able to do your job of mitigating damage and holding threat better. Simple and logical enough, isn't it?
Now the issue I have with BoSanc is twofold: It's a unique blessing only acquirable by Prot Paladins and some raids, like mine, just don't have room for another tank because we have 2 good Warrior tanks and a DK/Feral to fill in as DPS/3rd tank. The second issue: BoSanc is too good. It's giving us so much rage that managing your rage gets trivialized. It's basically the other side of the extreme. I'd really like to see something inbetween that is not tied to a unique blessing and hey, we might see something like this in 3.1 because I am pretty sure Blizzard is aware of this issue because they gave us Justified Killing in Beta (2/4 rage on parry/dodge). For some reason they removed this ability, even though the Druid version
Natural Reaction - Spell - World of Warcraft remained ingame (and their rage generation comes as a big part from white damage on top of this).
b) Enrage from improved Defensive Stance and Revenge
Revenge and our +10% damage modifier from being enraged are pretty big for our threat generation (and DPS, but more about that later). This may not be an apparent problem, because as long as we are MTing and getting hit, it doesn't matter. We get to Revenge on every cooldown and we do 10% more damage all the time. Now the problem occurs when either of these two things happen:
a) You OT a boss where you need to be second in threat (and one that is not tauntable) and that doesn't have an ability like Patchwerk that feeds you enrage/rage/revenge procs. While there is no such boss in the game yet, bosses like Bloodboil show that Blizzard can and most likely will design bosses with a similar mechanic so that could get us into trouble later.
b) You MT a boss but he doesn't melee you for whatever stupid reason. There is currently just one boss I know of that does this: Gothik. Yes, he is easy. Yes, he is tauntable but the point is that against bosses like these we might get into trouble later on when Blizzard's design team decides such a boss would be fun (maybe another Twins style encounter?).
(c) This will also go a long way in improving our DPS when we are in tanking gear but are DPSing like the 2nd tank on Thaddius.)
So how to fix this? Nerf Revenge damage and relocate it on either Devastate or Shield Slam (and ironically, Devastate in Beta had a 80% weapon damage modifier but they had to remove it and relocate it on Revenge because the Fury tree was so terrible back then that DW Flurry/Devastate was a dominant DPS spec. Now that Fury actually wants to DW 2 handers, this issue should be resolved and I have high hopes to see this change reverted).
I have no idea how to fix the Defensive Stance enrage apart from just making it proc from incoming spell damage or remove the Defensive Stance penalty altogether (
and they may be working on that already).
2) DPS while tanking
I'll keep this part short because I don't have any WWSes to back it up but alot of Warriors seemed to think they don't compare well in this area. Keep in mind that I am refering to the DPS Warriors do while tanking, in
full tanking gear (yes, I have seen Xav's video, and it's impressive for sure

). Why am I stressing this part? Imagine you are learning a boss with a tight enrage timer like Brutallus. Tank DPS is going to matter but so is survivability. I will bet you anything that you will not learn this fight in full expertise gear and DPS trinkets.
Anyways, what is your experience on this? Are we too low, just right, too high in comparison to other tanks?
Thoughts?